Don't init router in dashboard.js #2346
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2346 +/- ##
==========================================
- Coverage 26.55% 26.54% -0.01%
==========================================
Files 62 62
Lines 3069 3070 +1
Branches 681 681
==========================================
Hits 815 815
- Misses 2254 2255 +1 |
Member
|
@marcelklehr Thanks for this PR, this is a good idea. However, I decided that the router shouldn't be used in store at all. So I refactored this a bit in #2362. This Supersedes this PR here. |
Member
Author
|
Awesome, even better :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the tasks app is enabled, the dashboard script automatically appends
#/to the dashboard URL, because the router is initialized.