feat: add drawio mimetypes to prevent code signing errors#46729
feat: add drawio mimetypes to prevent code signing errors#46729tnyeanderson wants to merge 1 commit intonextcloud:masterfrom
Conversation
|
Thanks for your pull request 👍 Alternative: It's possible to overwrite/extend the mimetype mappings by placing a file "mimetypemapping.json" in the configuration folder. Other apps are using this approach, for example: https://github.com/jhass/nextcloud-keeweb/pull/135/files or https://github.com/ayselafsar/dicomviewer/blob/master/lib/Migration/RegisterMimeType.php |
server/tests/lib/IntegrityCheck/CheckerTest.php Lines 755 to 759 in 9ed6d1e |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Hey @kesselb, finally getting back to this... sorry for my delay. I'm trying to work through the steps you provided, but I haven't developed with nextcloud yet so I'm having a little trouble running the tests following the docs here. To try to accomplish step 1 in your link above, I'm running this: My goal is to use docker for this (to avoid cluttering my machine), and I figured I don't need to run this for every db type so I just chose mysql. I also am trying to run only the integrity check tests to save time. Could you give me some pointers on what I'm doing wrong here? |
Resolves: Core check fails after installing the app jgraph/drawio-nextcloud#26
Related: [Bug]: 25.0.3 fresh install fails integrity check #36368
Summary
Installing drawio on a nextcloud server causes a failed code signing check on
mimetypelist.jsas well as some "extra" SVG files for the MIME type.This PR adds these to core so the files do not need to be changed/added during the install process, which will avoid the code signing failures.
TODO
Checklist