feat: add mimetypes to nextcloud core

[tnyeanderson]

Fixes: #26

I've opened a PR for nextcloud server which adds the drawio mimetypes upstream to prevent code signing errors.

The above issue was locked to collaborators due to excessive "+1" posts, but this stopped the implementation conversation as well.

This PR prevents the installer from copying the SVG mimetype icons.

TODO

Where in the code does the core/js/mimetypelist.js file get manipulated? I'm not familiar with the nextcloud interfaces, but that will need to be removed as well.

[m-mohamedin]

Thanks for the PR
Both the images and mimetype additions are handled in the same file:
/lib/Migration/RegisterMimeType.php

See registerForExistingFiles and registerForNewFiles

Let us know if you have any other questions

[tnyeanderson]

I saw those functions, they are adding the mime types to the correct files, which are mimetypemapping.json and mimetypealiases.json. Those will not cause the code signing errors, if I understand the situation correctly.

However, on my system, the mimetypelist.js also has the drawio MIME types in it, which is what triggers the error and the problem.

I'm trying to understand how my mimetypelist.js file got changed, and I haven't seen any mention of that file in the entire git history of the repo (perhaps it's an imported constant?). Any ideas?

[m-mohamedin]

I saw those functions, they are adding the mime types to the correct files, which are mimetypemapping.json and mimetypealiases.json. Those will not cause the code signing errors, if I understand the situation correctly.

However, on my system, the mimetypelist.js also has the drawio MIME types in it, which is what triggers the error and the problem.

I'm trying to understand how my mimetypelist.js file got changed, and I haven't seen any mention of that file in the entire git history of the repo (perhaps it's an imported constant?). Any ideas?

Sorry for the delay, I wanted to dig deeper but I'm still busy
Unfortunately, I don't know how the file is changed, but these two functions do it afaik (code is copied from mindmap )

[raxetul]

Are these images important? What are they used for?

[tnyeanderson]

They are the thumbnail images used to represent items of the given MIME type

[m-mohamedin]

@tnyeanderson Are you blocked by us? I hope I answered all your questions

Mindmap added their mimetypes in this PR and commit, I think nextcloud has a standard process to add a new type but I forgot where I read about that:

nextcloud/server#27989
nextcloud/server@efb3481

[tnyeanderson]

At this point, i suspect that once the stuff is added upstream and this is merged, things will be fine again (maybe this is a quirk of my system which is many years old and has been through many updates--who knows).

I'll work on finalizing the upstream PR so this can be merged. Sorry for my delay