Merged
Conversation
ChristophWurst
previously requested changes
Apr 8, 2021
miaulalala
force-pushed
the
fix/spit-migrations-for-backport
branch
from
4fe6218 to
4331a6e
Compare
st3iny
approved these changes
Apr 9, 2021
Member
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
Checking out stable1.9 and adding lib/Migration/Version1095Date20210407150016.php manually will fix installing on nextcloud server master.
Nit: Rename lib/Migration/Version1095Date20210407150016.php to lib/Migration/Version1096Date20210407150016.php because v1.9.5 is already released.
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Let's rename to Version1096 indeed to take some of the potential confusion around a backported migration :)
Signed-off-by: Anna Larch <anna@nextcloud.com> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
fix/spit-migrations-for-backport
branch
from
d5e9ba5 to
4f54f3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #4903