Change mail_accounts.provisioned column to allow null#4903
Merged
miaulalala merged 1 commit intomasterfrom Apr 7, 2021
Merged
Conversation
miaulalala
force-pushed
the
fix/oracle-constraints
branch
from
d1b7d59 to
53bf631
Compare
miaulalala
force-pushed
the
fix/oracle-constraints
branch
2 times, most recently
from
a977358 to
b8bdef1
Compare
ChristophWurst
approved these changes
Apr 7, 2021
Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
fix/oracle-constraints
branch
from
9cf771d to
0c27b77
Compare
kesselb
reviewed
Apr 7, 2021
| $this->addType('outboundPort', 'integer'); | ||
| $this->addType('lastMailboxSync', 'integer'); | ||
| $this->addType('provisioned', 'bool'); | ||
| $this->addType('provisioned', 'boolean'); |
Contributor
There was a problem hiding this comment.
fyi bool and boolean should work: https://www.php.net/manual/en/function.settype.php
Member
There was a problem hiding this comment.
Yes, we discussed this and concluded some consistency would be nice :)
Contributor
There was a problem hiding this comment.
fine by me but weird to use boolean because for method signatures we need bool ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4897