Skip to content

Rework duplicate entry handling for tags#4840

Merged
miaulalala merged 1 commit intomasterfrom
enhancement/rework-duplicate-entries-for-tag-message
Apr 8, 2021
Merged

Rework duplicate entry handling for tags#4840
miaulalala merged 1 commit intomasterfrom
enhancement/rework-duplicate-entries-for-tag-message

Conversation

@miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Mar 27, 2021

Fixes #4833, #4825

@miaulalala miaulalala marked this pull request as ready for review March 30, 2021 15:00
@kesselb

This comment has been minimized.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor code style issues 🤓

@miaulalala

This comment has been minimized.

@miaulalala miaulalala marked this pull request as draft March 31, 2021 07:31
@ChristophWurst

This comment has been minimized.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise!

@miaulalala miaulalala force-pushed the enhancement/rework-duplicate-entries-for-tag-message branch from f55925c to 0902d2e Compare March 31, 2021 16:28
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the enhancement/rework-duplicate-entries-for-tag-message branch from 0902d2e to 4913892 Compare March 31, 2021 16:32
@miaulalala miaulalala marked this pull request as ready for review March 31, 2021 16:32
@miaulalala miaulalala linked an issue Apr 1, 2021 that may be closed by this pull request
Copy link
Collaborator

@StCyr StCyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does solve #4827 indeed. Thanks 🥳

@miaulalala miaulalala merged commit 68cbd65 into master Apr 8, 2021
@miaulalala miaulalala deleted the enhancement/rework-duplicate-entries-for-tag-message branch April 8, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

5 participants