Skip to content

fix: Refactor ref handling in PopChild component #3429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
constayush wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Refactor ref handling in PopChild component #3429

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5dadd0
Refactor ref handling in PopChild component
constayush Dec 22, 2025
0c8edb5
Refactor ref handling in PopChild component with backward compatibility
constayush Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/framer-motion/src/components/AnimatePresence/PopChild.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,9 @@ export function PopChild({ children, isPresent, anchorX, root }: Props) {
right: 0,
})
const { nonce } = useContext(MotionConfigContext)
const composedRef = useComposedRefs(
ref,
(children as { ref?: React.Ref<HTMLElement> })?.ref
)

const childRef = (children as any)?.ref ?? (children as any)?.props?.ref;
const composedRef = useComposedRefs(ref, childRef);

/**
* We create and inject a style block so we can apply this explicit
* sizing in a non-destructive manner by just deleting the style block.
Expand Down