fix: Refactor ref handling in PopChild component #3429
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In React 19, ref is no longer a special property on the element, Its just a normal prop so we have to do "children.props.ref" not children.ref
constayush
changed the title
Collaborator
|
Thanks for the PR! How does this work with React 18? |
Author
Thanks for reviewing, earlier fix won't work with React 18. I've updated the PR to be backwards compatible by adding nullish coalescing. |
In React 19, ref is now a regular prop instead of a special property Updated PopChild to check both children.ref of React 18 and children.props.ref of React 19 for backwards compatibility.
|
@constayush Maybe it should read from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In React 19, ref is no longer a special property on the element, Its just a normal prop so we have to do children.props.ref not children.ref
fixes: #3428