Merged
Conversation
… iframe (#8405) * Don't run sim in background when no project is loaded in the skillmap iframe * Don't reload header when exiting skillmp tutorial * Remove post progress
Co-authored-by: Eric Anderson <eanders@microsoft.com>
* Fix hang in monaco by making regex more specific * cleanup
* cloud status wip * reflect cloud status on info panel * removed unneeded property * show cloud status on skillmap view * pr feedback and refinements
…ud (#8456) * Make copies of local projects when importing skillmap progress to cloud * cleanup * PR feedback * always request all header cloud status
Contributor
Author
|
I'll keep this open until we're done working in stable7.1. |
* Copy skillmap headers over nicely for new users * Remove trailing spaces * Put ready promise back * Don't block things forever * Move things from ready to appstate * Add comment * Use 'some' instead of filter
Collaborator
|
Merge to master & bump? |
Contributor
Author
|
Sure, will do that shortly. |
Contributor
Author
|
PR needs sign off. |
abchatra
approved these changes
Sep 13, 2021
abchatra
approved these changes
Sep 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging stable7.1 to master.