Broaden generateChangelog mustRunAfter to all subproject tasks#588
Merged
wmoustafa merged 1 commit intolinkedin:masterfrom Mar 25, 2026
Merged
Conversation
The previous fix (linkedin#586) only listed 5 specific task names, but the release workflow runs additional tasks (javadoc, javadocJar, signJavaLibraryPublication, sourcesJar, etc.) that also conflict. Use mustRunAfter(subprojects.collect { it.tasks }) to cover all current and future subproject tasks. https://docs.gradle.org/8.6/userguide/validation_problems.html#implicit_dependency
wmoustafa
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #586. The previous fix only listed 5 specific task names, but the release workflow runs additional tasks (
javadoc,javadocJar,signJavaLibraryPublication,sourcesJar, etc.) that also conflict withgenerateChangelogunder Gradle 8's strict task dependency validation.This fix uses
mustRunAfter(subprojects.collect { it.tasks })to cover all subproject tasks — no more adding individual task names as new conflicts are discovered.Test plan
./gradlew spotlessCheckpasses./gradlew githubRelease --dry-runpassespublishToSonatypelocally (requires Sonatype credentials), but the fix is structurally complete — it covers all subproject tasks, not a subset