Fix release workflow for Gradle 8.6 compatibility#586
Merged
wmoustafa merged 2 commits intolinkedin:masterfrom Mar 25, 2026
Merged
Fix release workflow for Gradle 8.6 compatibility#586wmoustafa merged 2 commits intolinkedin:masterfrom
wmoustafa merged 2 commits intolinkedin:masterfrom
Conversation
The generateChangelog task from shipkit shares the project root directory with compilation tasks. Gradle 8 enforces strict implicit dependency validation and fails when tasks use overlapping directories without declaring dependencies. Add mustRunAfter to resolve the ordering.
wmoustafa
approved these changes
Mar 24, 2026
YogeshKothari26
added a commit
to YogeshKothari26/coral
that referenced
this pull request
Mar 25, 2026
The previous fix (linkedin#586) only listed 5 specific task names, but the release workflow runs additional tasks (javadoc, javadocJar, signJavaLibraryPublication, sourcesJar, etc.) that also conflict. Use mustRunAfter(subprojects.collect { it.tasks }) to cover all current and future subproject tasks. https://docs.gradle.org/8.6/userguide/validation_problems.html#implicit_dependency
wmoustafa
pushed a commit
that referenced
this pull request
Mar 25, 2026
The previous fix (#586) only listed 5 specific task names, but the release workflow runs additional tasks (javadoc, javadocJar, signJavaLibraryPublication, sourcesJar, etc.) that also conflict. Use mustRunAfter(subprojects.collect { it.tasks }) to cover all current and future subproject tasks. https://docs.gradle.org/8.6/userguide/validation_problems.html#implicit_dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Gradle 6.7.1 → 8.6 upgrade (#580) introduced strict task dependency validation that breaks the release workflow. The
generateChangelogtask from shipkit shares the project root directory with compilation tasks, and Gradle 8 flags this as an implicit dependency.This was not caught in CI because the release tasks (
githubRelease,publishToSonatype) are only run in the release workflow, not in the build/test checks.Fix
Add
mustRunAfterdeclaration togenerateChangelog— this is solution #3 from Gradle's own validation guide:See also: Gradle docs on task ordering.
Test plan
./gradlew githubRelease --dry-runpasses locallygradle/shipkit.gradle— no production code changesNote
Tested with
--dry-runwhich validates task configuration but does not execute tasks. If the release still fails after merge, the fallback fix would be to redirectgenerateChangelog's output to a dedicated directory to avoid the directory overlap entirely.