[Merged by Bors] - chore: golf proofs #33559
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary 70e9ecf4e8Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Collaborator
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by tb65536. |
leanprover-community-mathlib4-bot
added
the
maintainer-merge
leanprover-community-mathlib4-bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 5, 2026
The goal of this golfing PR is to decrease the number of times lemmas are called explicitly (replacing calls to lemmas with calls to tactics). Any decrease in compilation time is a welcome side effect, although it is not a primary objective. Trace profiling results (shown if ≥10 ms before or after): * `Submodule.exists_norm_eq_iInf_of_complete_subspace`: 140 ms before, 111 ms after 🎉 * `Submodule.norm_eq_iInf_iff_inner_eq_zero`: 225 ms before, 193 ms after 🎉 * `CategoryTheory.PreGaloisCategory.has_decomp_quotients`: 282 ms before, 253 ms after 🎉 * `lipschitzGroup.conjAct_smul_ι_mem_range_ι`: 216 ms before, 191 ms after 🎉 * `Module.Basis.card_le_card_of_linearIndependent`: 94 ms before, 62 ms after 🎉 * `Submodule.quotDualCoannihilatorToDual_nondegenerate`: 102 ms before, 90 ms after 🎉 * `Submodule.eq_top_of_finrank_eq`: 430 ms before, 334 ms after 🎉 * `Submodule.LinearDisjoint.of_basis_left`: 101 ms before, 91 ms after 🎉 * `Submodule.LinearDisjoint.of_basis_right`: 100 ms before, 94 ms after 🎉 * `LinearMap.BilinForm.toQuadraticMap_isOrtho`: 89 ms before, 74 ms after 🎉 * `NumberField.InfinitePlace.card_isUnramified`: 338 ms before, 286 ms after 🎉 * `NumberField.InfinitePlace.card_isUnramified_compl`: 352 ms before, 297 ms after 🎉 * `FiniteDimensional.exists_is_basis_integral`: 239 ms before, 200 ms after 🎉 This golfing PR is batched under the following guidelines: * Up to ~5 changed files per PR * Up to ~25 changed declarations per PR * Up to ~100 changed lines per PR
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
kim-em
pushed a commit
to kim-em/mathlib4
that referenced
this pull request
Jan 6, 2026
The goal of this golfing PR is to decrease the number of times lemmas are called explicitly (replacing calls to lemmas with calls to tactics). Any decrease in compilation time is a welcome side effect, although it is not a primary objective. Trace profiling results (shown if ≥10 ms before or after): * `Submodule.exists_norm_eq_iInf_of_complete_subspace`: 140 ms before, 111 ms after 🎉 * `Submodule.norm_eq_iInf_iff_inner_eq_zero`: 225 ms before, 193 ms after 🎉 * `CategoryTheory.PreGaloisCategory.has_decomp_quotients`: 282 ms before, 253 ms after 🎉 * `lipschitzGroup.conjAct_smul_ι_mem_range_ι`: 216 ms before, 191 ms after 🎉 * `Module.Basis.card_le_card_of_linearIndependent`: 94 ms before, 62 ms after 🎉 * `Submodule.quotDualCoannihilatorToDual_nondegenerate`: 102 ms before, 90 ms after 🎉 * `Submodule.eq_top_of_finrank_eq`: 430 ms before, 334 ms after 🎉 * `Submodule.LinearDisjoint.of_basis_left`: 101 ms before, 91 ms after 🎉 * `Submodule.LinearDisjoint.of_basis_right`: 100 ms before, 94 ms after 🎉 * `LinearMap.BilinForm.toQuadraticMap_isOrtho`: 89 ms before, 74 ms after 🎉 * `NumberField.InfinitePlace.card_isUnramified`: 338 ms before, 286 ms after 🎉 * `NumberField.InfinitePlace.card_isUnramified_compl`: 352 ms before, 297 ms after 🎉 * `FiniteDimensional.exists_is_basis_integral`: 239 ms before, 200 ms after 🎉 This golfing PR is batched under the following guidelines: * Up to ~5 changed files per PR * Up to ~25 changed declarations per PR * Up to ~100 changed lines per PR
goliath-klein
pushed a commit
to PrParadoxy/mathlib4
that referenced
this pull request
Jan 24, 2026
The goal of this golfing PR is to decrease the number of times lemmas are called explicitly (replacing calls to lemmas with calls to tactics). Any decrease in compilation time is a welcome side effect, although it is not a primary objective. Trace profiling results (shown if ≥10 ms before or after): * `Submodule.exists_norm_eq_iInf_of_complete_subspace`: 140 ms before, 111 ms after 🎉 * `Submodule.norm_eq_iInf_iff_inner_eq_zero`: 225 ms before, 193 ms after 🎉 * `CategoryTheory.PreGaloisCategory.has_decomp_quotients`: 282 ms before, 253 ms after 🎉 * `lipschitzGroup.conjAct_smul_ι_mem_range_ι`: 216 ms before, 191 ms after 🎉 * `Module.Basis.card_le_card_of_linearIndependent`: 94 ms before, 62 ms after 🎉 * `Submodule.quotDualCoannihilatorToDual_nondegenerate`: 102 ms before, 90 ms after 🎉 * `Submodule.eq_top_of_finrank_eq`: 430 ms before, 334 ms after 🎉 * `Submodule.LinearDisjoint.of_basis_left`: 101 ms before, 91 ms after 🎉 * `Submodule.LinearDisjoint.of_basis_right`: 100 ms before, 94 ms after 🎉 * `LinearMap.BilinForm.toQuadraticMap_isOrtho`: 89 ms before, 74 ms after 🎉 * `NumberField.InfinitePlace.card_isUnramified`: 338 ms before, 286 ms after 🎉 * `NumberField.InfinitePlace.card_isUnramified_compl`: 352 ms before, 297 ms after 🎉 * `FiniteDimensional.exists_is_basis_integral`: 239 ms before, 200 ms after 🎉 This golfing PR is batched under the following guidelines: * Up to ~5 changed files per PR * Up to ~25 changed declarations per PR * Up to ~100 changed lines per PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this golfing PR is to decrease the number of times lemmas are called explicitly (replacing calls to lemmas with calls to tactics). Any decrease in compilation time is a welcome side effect, although it is not a primary objective.
Trace profiling results (shown if ≥10 ms before or after):
Submodule.exists_norm_eq_iInf_of_complete_subspace: 140 ms before, 111 ms after 🎉Submodule.norm_eq_iInf_iff_inner_eq_zero: 225 ms before, 193 ms after 🎉CategoryTheory.PreGaloisCategory.has_decomp_quotients: 282 ms before, 253 ms after 🎉lipschitzGroup.conjAct_smul_ι_mem_range_ι: 216 ms before, 191 ms after 🎉Module.Basis.card_le_card_of_linearIndependent: 94 ms before, 62 ms after 🎉Submodule.quotDualCoannihilatorToDual_nondegenerate: 102 ms before, 90 ms after 🎉Submodule.eq_top_of_finrank_eq: 430 ms before, 334 ms after 🎉Submodule.LinearDisjoint.of_basis_left: 101 ms before, 91 ms after 🎉Submodule.LinearDisjoint.of_basis_right: 100 ms before, 94 ms after 🎉LinearMap.BilinForm.toQuadraticMap_isOrtho: 89 ms before, 74 ms after 🎉NumberField.InfinitePlace.card_isUnramified: 338 ms before, 286 ms after 🎉NumberField.InfinitePlace.card_isUnramified_compl: 352 ms before, 297 ms after 🎉FiniteDimensional.exists_is_basis_integral: 239 ms before, 200 ms after 🎉This golfing PR is batched under the following guidelines: