Skip to content

Conversation

@vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Dec 9, 2025

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

PR summary c96081d930

Import changes exceeding 2%

% File
+2.21% Mathlib.RingTheory.HahnSeries.Cardinal

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.RingTheory.HahnSeries.Cardinal 858 877 +19 (+2.21%)
Import changes for all files
Files Import difference
Mathlib.RingTheory.HahnSeries.Cardinal 19

Declarations diff

+ cardSupp_div_le
+ cardSupp_hsum_le
+ cardSupp_hsum_powers_le
+ cardSupp_inv_le
+ cardSupp_mul_single_le
+ cardSupp_one
+ cardSupp_one_le
+ cardSupp_pow_le
+ cardSupp_single_mul_le
+ coeff_mul_single
+ coeff_order_eq_zero
+ coeff_single_mul

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-ring-theory Ring theory label Dec 9, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Dec 9, 2025
@mathlib4-merge-conflict-bot
Copy link
Collaborator

This pull request has conflicts, please merge master and resolve them.

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 10, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 10, 2025
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 11, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Dec 22, 2025
@mathlib4-dependent-issues-bot
Copy link
Collaborator

@vihdzp vihdzp requested a review from wwylele December 22, 2025 21:08
Co-authored-by: Weiyi Wang <wwylele@gmail.com>
@vihdzp vihdzp requested a review from YaelDillies December 25, 2025 00:48
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does cardSupp exist? I am worried that we are adding API to a useless wrapper.

@vihdzp
Copy link
Collaborator Author

vihdzp commented Dec 25, 2025

κ-bounded Hahn series appear quite a bit in the literature. In particular, the surreals are univ-bounded (small) real Hahn series with their order dual as value group.

The next PR in this series defines the subfield of κ-bounded Hahn series for uncountable κ, on which some 2,000 lines of code on the CGT repo currently depend.

@YaelDillies
Copy link
Collaborator

YaelDillies commented Dec 25, 2025

Great! so \kappa-bounded Hahn series is a useful concept. What I think is a useless concept that of the cardinality of a Hahn series, in the sense that it is merely the cardinality of its support.

In the PR introducing cardSupp, I see you argued that cardinalMk_support was poor naming, and that introducing cardSupp would fix that. But that argument assumed that one would write Cardinal.mk (HahnSeries.support x), while in fact it should be Set.card (HahnSeries.support x), whose name in lemmas would be card_support, which I find perfectly acceptable. If that's still too long for you, then I would advise renaming HahnSeries.support to HahnSeries.supp instead of adding cardSupp.

@vihdzp
Copy link
Collaborator Author

vihdzp commented Dec 25, 2025

I don't believe Set.card is a thing? I've been under the impression that the way to write the cardinality of a set is to use Cardinal.mk directly.

As for renaming support to supp, this would run counter to what we do for Function.support, Polynomial.support, Module.support, Equiv.Perm.support, and PMF.support.

@vihdzp
Copy link
Collaborator Author

vihdzp commented Dec 26, 2025

Is there any harm in having cardSupp if it is in fact an object of interest within the theory of Hahn series? Or should I rewrite this entire file in terms of cardinalMk_support?

@erdOne
Copy link
Member

erdOne commented Dec 27, 2025

I don't think cardSupp is an unuseful wrapper. I think this PR and the previous PR already demonstrated that there are enough results about this idea that it warrants special API support, and having this wrapper is useful in pointing people to these API.
Other than this issue I think this PR is ready to go and I think some third opinion here to unblock this PR would be useful.

maintainer merge?

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by erdOne.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 27, 2025
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Jan 2, 2026
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jan 2, 2026
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 2, 2026

Pull request successfully merged into master.

Build succeeded!

And happy new year! 🎉

@mathlib-bors mathlib-bors bot changed the title feat: cardinality of Hahn series inverse [Merged by Bors] - feat: cardinality of Hahn series inverse Jan 2, 2026
@mathlib-bors mathlib-bors bot closed this Jan 2, 2026
kim-em pushed a commit to kim-em/mathlib4 that referenced this pull request Jan 6, 2026
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
@adomani adomani mentioned this pull request Jan 16, 2026
goliath-klein pushed a commit to PrParadoxy/mathlib4 that referenced this pull request Jan 24, 2026
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large-import Automatically added label for PRs with a significant increase in transitive imports ready-to-merge This PR has been sent to bors. t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants