-
Notifications
You must be signed in to change notification settings - Fork 1k
[Merged by Bors] - feat: cardinality of Hahn series inverse #32643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR summary c96081d930Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.HahnSeries.Cardinal | 858 | 877 | +19 (+2.21%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.RingTheory.HahnSeries.Cardinal |
19 |
Declarations diff
+ cardSupp_div_le
+ cardSupp_hsum_le
+ cardSupp_hsum_powers_le
+ cardSupp_inv_le
+ cardSupp_mul_single_le
+ cardSupp_one
+ cardSupp_one_le
+ cardSupp_pow_le
+ cardSupp_single_mul_le
+ coeff_mul_single
+ coeff_order_eq_zero
+ coeff_single_mul
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
|
This pull request has conflicts, please merge |
|
This PR/issue depends on: |
Co-authored-by: Weiyi Wang <wwylele@gmail.com>
YaelDillies
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does cardSupp exist? I am worried that we are adding API to a useless wrapper.
|
κ-bounded Hahn series appear quite a bit in the literature. In particular, the surreals are univ-bounded (small) real Hahn series with their order dual as value group. The next PR in this series defines the subfield of κ-bounded Hahn series for uncountable κ, on which some 2,000 lines of code on the CGT repo currently depend. |
|
Great! so In the PR introducing |
|
I don't believe As for renaming |
|
Is there any harm in having |
|
I don't think maintainer merge? |
|
🚀 Pull request has been placed on the maintainer queue by erdOne. |
jcommelin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded! And happy new year! 🎉 |
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
sum (fun n : ℕ ↦ x ^ n)#32645