-
Notifications
You must be signed in to change notification settings - Fork 1k
[Merged by Bors] - feat: cardinality of Hahn series #32640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR summary 4d33172004Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
This reverts commit 2495d85.
wwylele
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How standard is the name "cardinality"? At first I thought this would be about the cardinality of the entire HahnSeries type (= card R ^ card Γ?). I convinced myself that this is the correct name by analogy to Multiset.card (viewing Multiset as Finsupp), but I'd like to know if this term already appears in the literature.
Other than this, looks good to me
| exact coeff_single_zero_mul | ||
|
|
||
| theorem support_mul_subset_add_support [NonUnitalNonAssocSemiring R] {x y : HahnSeries Γ R} : | ||
| theorem support_mul_subset [NonUnitalNonAssocSemiring R] {x y : HahnSeries Γ R} : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the previous name was not wrong, I don't know if it is worth the churn to rename and deprecate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea here was to make the names of all these lemmas consistent. support_add_subset, support_sub_subset, support_smul_subset, etc. But I can revert if you want.
|
I can't really find anyone calling this anything beyond "the cardinality of the support". But I hope you agree that a more explicit name like |
|
This pull request has conflicts, please merge |
|
This pull request has conflicts, please merge |
|
Thanks! This seems reasonable. |
|
🚀 Pull request has been placed on the maintainer queue by erdOne. |
jcommelin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second the cardSupp suggestion.
jcommelin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
This is a very preliminary development; most of the PR is really just lemmas about `HahnSeries.support`. This will be needed in the CGT repo, to define surreal Hahn series as the subfield of real, small Hahn series over their own order dual. Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
This is a very preliminary development; most of the PR is really just lemmas about
HahnSeries.support. This will be needed in the CGT repo, to define surreal Hahn series as the subfield of real, small Hahn series over their own order dual.