Skip to content

Conversation

@vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Dec 9, 2025

This is a very preliminary development; most of the PR is really just lemmas about HahnSeries.support. This will be needed in the CGT repo, to define surreal Hahn series as the subfield of real, small Hahn series over their own order dual.


Open in Gitpod

@vihdzp vihdzp added the t-algebra Algebra (groups, rings, fields, etc) label Dec 9, 2025
@vihdzp vihdzp requested a review from wwylele December 9, 2025 09:31
@github-actions github-actions bot added the t-ring-theory Ring theory label Dec 9, 2025
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

PR summary 4d33172004

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.RingTheory.HahnSeries.Cardinal (new file) 855

Declarations diff

+ cardSupp
+ cardSupp_add_le
+ cardSupp_congr
+ cardSupp_map_le
+ cardSupp_mono
+ cardSupp_mul_le
+ cardSupp_neg
+ cardSupp_neg_le
+ cardSupp_single_le
+ cardSupp_single_of_ne
+ cardSupp_smul_le
+ cardSupp_sub_le
+ cardSupp_truncLT_le
+ cardSupp_zero
+ support_map_subset
+ support_mk
+ support_mul_subset
+ support_neg_subset
+ support_smul_subset
+ support_sub_subset
+ support_truncLT
+ support_truncLT_subset

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Collaborator

@wwylele wwylele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How standard is the name "cardinality"? At first I thought this would be about the cardinality of the entire HahnSeries type (= card R ^ card Γ?). I convinced myself that this is the correct name by analogy to Multiset.card (viewing Multiset as Finsupp), but I'd like to know if this term already appears in the literature.

Other than this, looks good to me

exact coeff_single_zero_mul

theorem support_mul_subset_add_support [NonUnitalNonAssocSemiring R] {x y : HahnSeries Γ R} :
theorem support_mul_subset [NonUnitalNonAssocSemiring R] {x y : HahnSeries Γ R} :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the previous name was not wrong, I don't know if it is worth the churn to rename and deprecate

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea here was to make the names of all these lemmas consistent. support_add_subset, support_sub_subset, support_smul_subset, etc. But I can revert if you want.

@vihdzp
Copy link
Collaborator Author

vihdzp commented Dec 9, 2025

I can't really find anyone calling this anything beyond "the cardinality of the support". But I hope you agree that a more explicit name like cardinalMk_support would be overly verbose.

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 10, 2025
@mathlib4-merge-conflict-bot
Copy link
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 10, 2025
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 11, 2025
@mathlib4-merge-conflict-bot
Copy link
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 11, 2025
@erdOne
Copy link
Member

erdOne commented Dec 13, 2025

Thanks! This seems reasonable.
About the name: perhaps cardSupp? I don't have a strong opinion here.
maintainer delegate

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by erdOne.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 13, 2025
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second the cardSupp suggestion.

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Dec 15, 2025
@vihdzp vihdzp removed the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 15, 2025
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Dec 15, 2025
mathlib-bors bot pushed a commit that referenced this pull request Dec 15, 2025
This is a very preliminary development; most of the PR is really just lemmas about `HahnSeries.support`. This will be needed in the CGT repo, to define surreal Hahn series as the subfield of real, small Hahn series over their own order dual.

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 15, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: cardinality of Hahn series [Merged by Bors] - feat: cardinality of Hahn series Dec 15, 2025
@mathlib-bors mathlib-bors bot closed this Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants