Show tagged groups Public Users

[jessewoo]

Source JIRA card(s) and hubzero ticket(s)

• Previous PR: Allow groups to show in tag search results for public visitors #1615
• https://sdx-sdsc.atlassian.net/browse/VHUB-9
• https://theghub.org/support/ticket/2601

Brief summary of the issue
When a user adds a tag to a group, and upon searching for a tag, that specific group won't appear in the search results for public visitors but will appear for registered and logged in users.

An example is on the search results of https://theghub.org/tags/ghub. The ISMIP6 group has the associated "Ghub" tag. But that ISMIP6 group only shows up in the results when the user is registered and logged in. The issue is how we can make groups show up for specific tags in the search results for non-registered (public) users.

Brief summary of the fix

• The search SQL statement originally filtered out those groups. Talking it over, Nick added conditions to removed the "from" from guests and users in role that view all groups (admin).

Brief summary of your testing
Manual testing locally. It works where group shows up logged in or public.

Do the change needs to be hotfixed to any production hubs before a normal core rollout
No

Double check someone is assigned to review the ticket
Yes - Nick and David

[jessewoo]

@dbenham - could we review this in our next dev meeting?

[jessewoo]

@nkissebe - thank you for the sql query

[jessewoo]

@dbenham - ready to be merged.

[dbenham]

Group reviewed on Nov 8th, only feedback was whitespace which was addressed.