Allow groups to show in tag search results for public visitors

[jessewoo]

Source JIRA card(s) and hubzero ticket(s)

• https://sdx-sdsc.atlassian.net/browse/VHUB-9
• https://theghub.org/support/ticket/2601

Brief summary of the issue
When a user adds a tag to a group, and upon searching for a tag, that specific group won't appear in the search results for public visitors but will appear for registered and logged in users.

An example is on the search results of https://theghub.org/tags/ghub. The ISMIP6 group has the associated "Ghub" tag. But that ISMIP6 group only shows up in the results when the user is registered and logged in. The issue is how we can make groups show up for specific tags in the search results for non-registered (public) users.

Brief summary of the fix

• The search SQL statement originally filtered out those groups, so removed the filter for public users.

Brief summary of your testing
Manual testing

Do the change needs to be hotfixed to any production hubs before a normal core rollout
No

Double check someone is assigned to review the ticket
Yes - Nick and David

[dbenham]

LGTM.

Next time for the testing feedback, I'm looking for more of a description of what you did to test to confirm your change works as expected:

For a bug fix, something like:
"I ran the code before my fix with some input and it returned/behaved like X, after I applied my fix I re-ran the test with the same input and the expected result of (whatever expected restult) showed up properly"

OR

for a new feature, something like:
"This was a new feature, I ran tests with various inputs, range tested inputs 1,2,3,4, and made sure there were max length tests on fields 1,2,3,4. Logged out, feature was unavailable (this is the expected behavior). Talked with client, they took a look at it and said it was fine, or I went through the design doc (section xxx) to make sure all design criteria were properly"