update from origin#1861
Closed
vy12021 wants to merge 225 commits intogoogle:release-v2from
vy12021:master
Closed
Conversation
- Bump version. - Remove AC3 renderer. It's not ready.
dev -> dev-1.2.0-rc
dev-1.2.0-rc -> master
Correctly reset ADTSreader state
- This change: 1. Extracts HlsExtractor interface from TsExtractor. 2. Adds AdtsExtractor for AAC/ADTS streams, which turned out to be really easy. Selection of the ADTS extractor relies on seeing the .aac extension. This is at least guaranteed not to break anything that works already (since no-one is going to be using .aac as the extension for something that's not elementary AAC/ADTS). Issue: #209
Some extractor implementations underneath MediaExtractor require a seekTo call after tracks are selected to ensure samples are read from the correct position. De-duplicating logic was preventing this from happening in some cases, causing issues like: #301 Note that seeking all tracks a side effect of track selection sucks if you already have one or more tracks selected, because it introduces discontinuities to the already selected tracks. However, in general, it *is* necessary to specify the position for the track being selected, because the underlying extractor doesn't have enough information to know where to start reading from. It can't determine this based on the read positions of the already selected tracks, because the samples in these tracks might be very sparse with respect to time. I think a more optimal fix would be to change the SampleExtractor interface to receive the current position as an argument to selectTrack. For our own extractors, we'd seek the newly selected track to that position, whilst the already enabled tracks would be left in their current positions (if possible). For FrameworkSampleExtractor we'd still have no choice but to call seekTo on the extractor to seek all of the tracks. This solution ends up being more complex though, because: - The SampleExtractor then needs a way of telling DefaultSampleSource which tracks were actually seeked, so that the pendingDiscontinuities flags can be set correctly. - It's a weird API that requires the "current playback position to seek only the track being enabled" So it may not be worth it! I think this fix is definitely good for now, in any case. Issue: #301
Previous regular expression for extracting codec information was wrong, given a line that defines a variant it added information from “CODEC=“ text to the end of the line (including also information about RESOLUTION or alternate rendition groups as part of the CODEC field). This is not causing a functional problem (at least known by me) although is making codecs field storing information that is not related with the codec.
- Data needs to be unescaped before it's passed to SeiReader. - SeiReader should loop over potentially multiple child messages. - I also changed the sample passed to the EIA-608 renderer so that it's the entire sei message payload. The first 8 bytes are unnecessary, but it seems nicer conceptually to do it this way. Issue: #295
1.2.2 release
1. Clear prefixFlags when a NAL unit is found. 2. continueBuffering should return true if loading is finished.
Merge minor release 1.2.3
Minor release to enhance DASH mpd parsing
Release 1.3.2
Issue: #479
Fixes issue where an NPE occurs when RollingSampleBuffer is created with a null Allocator.
UdpDataSource: allow to setup socket timeout, change default timeout from infinite to 8000 milliseconds
This method is needed by FlacExtractor to release native resources. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=118769990
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=118778155
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=118921673
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=118924287
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=118935299
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=118935398
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=118936240
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=118941196
When there is not enough bytes to read a word Libflac keeps the left bytes in the read buffer and does a read with a reduced length by 1 to 3 bytes. This results to reading 8191, 1, 8191, 1, 8191... bytes. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=119048705
Fourcc vc1 metadata parse support
Add 16 bit PCM audio track detected including MS ACM for >2 channels
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.