Conversation
Support setting properties on MediaDrm
support content uri (e.q. content://xxx)
When a XING header is present but not usable (due to missing fields), CBR seeking can be used instead. It relies on the bitrate. The bitrate from the unusable XING header is not correct, which leads to incorrect seeking. Also fix VBRI seeking by setting the correct offset on the frame to parse. Few people seem to use that format, but I have found two very short truncated samples which were falling back to the CBR case before but are using VBRI with this change.
When I moved the id3Reader instantiation out of the while loop (below where it is now) it was no longer guarded by the streamTypes.get(streamType) deduping check. This brings back an equivalent check.
1. Make DefaultUriDataSource robust against exceptions through from close(). 2. Make AssetDataSource handle file:///android_asset/ URIs.
- Make HlsPlaylistParser treat non-positive dimensions as unknown. - Make HlsPlaylistParser parse floating point resolutions, because technically that's how they're spec'd. - Make VideoFormatSelectorUtil treat non-position dimensions as unknown. Issue: #461
Before preparation, and when seeking, Mp3Extractor did not handle retrying: - synchronizedHeader was set before the header was known to be valid, which means that after seeing one valid frame header and then failing to read, the synchronization would be treated as complete. - The input buffer would keep data loaded during synchronization but on the next call to synchronize when retrying it was not returned to the mark position to re-parse the data. This change fixes these issues.
- There's definitely potential for more code sharing in these classes, but deferring for now. - Also made no-scheme default to file://, and allowed smoothstreaming URLs to be specified with or without the /Manifest suffix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.