Skip to content

Partial clean up wrt mypy and black #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 21, 2023
Merged

Partial clean up wrt mypy and black #1617

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
31ac93b
Do not typecheck submodule
bodograumann Jul 20, 2023
b55cf65
Define supported version for mypy
bodograumann Jul 20, 2023
76394d4
Ignore remaining [unreachable] type errors
bodograumann Jul 20, 2023
c6dab19
Allow explicit casting even when slightly redundant
bodograumann Jul 20, 2023
6035db0
Run black and exclude submodule
bodograumann Jul 20, 2023
3908e79
Add missing type annotation
bodograumann Jul 20, 2023
f01ee4f
Apply straight-forward typing fixes
bodograumann Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ignore remaining [unreachable] type errors
  • Loading branch information
@bodograumann
bodograumann committed Jul 20, 2023
commit 76394d42ce2a33b4db71fd64763c1e9dae136747
2 changes: 1 addition & 1 deletion git/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def refresh(path: Optional[PathLike] = None) -> None:
if not Git.refresh(path=path):
return
if not FetchInfo.refresh():
return
return # type: ignore [unreachable]

GIT_OK = True

Expand Down
4 changes: 2 additions & 2 deletions git/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,8 @@ def get_config_path(config_level: Lit_config_levels) -> str:
raise ValueError("No repo to get repository configuration from. Use Repo._get_config_path")
else:
# Should not reach here. Will raise ValueError if does. Static typing will warn missing elifs
assert_never(
config_level, # type: ignore[unreachable]
assert_never( # type: ignore[unreachable]
config_level,
ValueError(f"Invalid configuration level: {config_level!r}"),
)

Expand Down
4 changes: 2 additions & 2 deletions git/repo/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,8 +549,8 @@ def _get_config_path(self, config_level: Lit_config_levels, git_dir: Optional[Pa
return osp.normpath(osp.join(repo_dir, "config"))
else:

assert_never(
config_level, # type:ignore[unreachable]
assert_never( # type:ignore[unreachable]
config_level,
ValueError(f"Invalid configuration level: {config_level!r}"),
)

Expand Down