Skip to content

Partial clean up wrt mypy and black #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 21, 2023
Merged

Partial clean up wrt mypy and black #1617

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
31ac93b
Do not typecheck submodule
bodograumann Jul 20, 2023
b55cf65
Define supported version for mypy
bodograumann Jul 20, 2023
76394d4
Ignore remaining [unreachable] type errors
bodograumann Jul 20, 2023
c6dab19
Allow explicit casting even when slightly redundant
bodograumann Jul 20, 2023
6035db0
Run black and exclude submodule
bodograumann Jul 20, 2023
3908e79
Add missing type annotation
bodograumann Jul 20, 2023
f01ee4f
Apply straight-forward typing fixes
bodograumann Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing type annotation
  • Loading branch information
@bodograumann
bodograumann committed Jul 20, 2023
commit 3908e79baf27b3d65265ca75db216f9368748351
2 changes: 1 addition & 1 deletion git/index/fun.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def hook_path(name: str, git_dir: PathLike) -> str:
return osp.join(git_dir, "hooks", name)


def _has_file_extension(path):
def _has_file_extension(path: str) -> str:
return osp.splitext(path)[1]


Expand Down