-
Notifications
You must be signed in to change notification settings - Fork 84
Track active taxonomy in taxonomy view in URL #7113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile OverviewGreptile SummaryThis PR adds URL tracking for the active taxonomy in the taxonomy view, allowing users to navigate directly to specific taxonomies (e.g., Changes:
Issues found:
Confidence Score: 2/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 1 comment
clients/admin-ui/src/features/taxonomy/components/TaxonomyPageContent.tsx
Outdated
Show resolved
Hide resolved
…hub.com/ethyca/fides into jpople/2025-12-11/track-taxonomy-in-url
speaker-ender
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as intended.
Small code nits but approving as is.
clients/admin-ui/src/features/taxonomy/components/TaxonomyPageContent.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/taxonomy/components/TaxonomyPageContent.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/taxonomy/components/TaxonomyPageContent.tsx
Show resolved
Hide resolved
clients/admin-ui/src/features/taxonomy/components/TaxonomyPageContent.tsx
Outdated
Show resolved
Hide resolved
| // Update URL when taxonomy changes, preserving query parameters | ||
| const query = { ...router.query }; | ||
| delete query.key; | ||
| router.replace( | ||
| { | ||
| pathname: `/taxonomy/${key}`, | ||
| query, | ||
| }, | ||
| undefined, | ||
| { shallow: true }, | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What query params need to be preserved?
This could be simplified if there is no need to preserve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This view supports a show_disabled_items query param which needs to be preserved, do you prefer handling that explicitly?
Ticket ENG-2212
Description Of Changes
When viewing taxonomies on /taxonomy, the URL now updates when clicking between them and you can link to e.g.
/taxonomy/data_subjectto navigate directly to one.Code Changes
initialTaxonomypropSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works