Conversation
|
I think at this point we should be consistent with the rest of the repos. Can you please submit this change into Arcade? |
|
Matched version used by dotnet/arcade#15404. |
I see the test failure in multiple legs. Exit code 134 means out of memory. I'm slightly concerned about this as it happens even after a retry. |
|
Happened again after a retry and the failure is isolated to this PR. Maybe a GC hole? @stephentoub for regex, any ideas? |
|
From @jkotas offline:
|
|
This is the stacktrace that's pointing to the problem: There are 2 issues:
|
|
|
|
That is only fixing the error printing. First one is the real issue:
|
|
Also, the fix for the second issue is in the live test runtime, so you do not need to wait for updated SDK to pick it up. |
|
The tests are failing with the You should be able to take it from here. I do not plan to investigate this one. |
|
@am11 gently asking whether you can further investigate? I'm currently quite stretched for time. |
|
@ViktorHofer you asked this question two years ago dotnet/sdk#32598 (comment). Sounds like you had a good hunch that this day is coming. It's the same dependency causing issue. The future is now! 😅 |
|
Interesting. Are you saying that we have torn state in the SDK that should get fixed? Which component brings an out-of-sync version of CodeAnalysis in? |
|
I was searching in SDK issue tracker and found that previous discussion about Microsoft.CodeAnalysis.CSharp FileNotFoundException. I tried matching analyzer versions with compiler in the last few commits but it didn't help. |
|
Lets wait for preview 1 then. |
|
I wonder if dotnet/arcade#15455 will fix the CodeAnalysis issues when running tests. We reverted a deps.json change which excluded too many assets from getting added to it. |
|
We can try. |
|
There are wasm test failures
|
|
ok, your previous comment sounded like you want me to reopen try again. |
No description provided.