Skip to content

[automated] Merge branch 'vs17.12' => 'vs17.14'#11991

Merged
rainersigwald merged 63 commits intovs17.14from
merge/vs17.12-to-vs17.14
Jun 13, 2025
Merged

[automated] Merge branch 'vs17.12' => 'vs17.14'#11991
rainersigwald merged 63 commits intovs17.14from
merge/vs17.12-to-vs17.14

Conversation

@github-actions
Copy link
Contributor

I detected changes in the vs17.12 branch which have not been merged yet to vs17.14. I'm a robot and am configured to help you automatically keep vs17.14 up to date, so I've opened this PR.

This PR merges commits made on vs17.12 by the following committers:

Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.

merge button instructions

If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.

Instructions for merging via command line

Run these commands to merge this pull request from the command line.

git fetch
git checkout vs17.12
git pull --ff-only
git checkout vs17.14
git pull --ff-only
git merge --no-ff vs17.12

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet/msbuild HEAD:merge/vs17.12-to-vs17.14
or if you are using SSH
git push git@github.com:dotnet/msbuild HEAD:merge/vs17.12-to-vs17.14

After PR checks are complete push the branch

git push

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/vs17.12-to-vs17.14'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
The provided examples assume that the remote is named 'origin'. If you have a different remote name, please replace 'origin' with the name of your remote.

git fetch
git checkout -b merge/vs17.12-to-vs17.14 origin/vs17.14
git pull https://github.com/dotnet/msbuild merge/vs17.12-to-vs17.14
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet/msbuild HEAD:merge/vs17.12-to-vs17.14
or if you are using SSH
git fetch
git checkout -b merge/vs17.12-to-vs17.14 origin/vs17.14
git pull git@github.com:dotnet/msbuild merge/vs17.12-to-vs17.14
(make changes)
git commit -m "Updated PR with my changes"
git push git@github.com:dotnet/msbuild HEAD:merge/vs17.12-to-vs17.14

Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.

dotnet-maestro bot and others added 30 commits March 18, 2025 09:11
* Update dependencies from https://github.com/dotnet/arcade build 20250220.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25114.5 -> To Version 8.0.0-beta.25120.1

* Update Versions.props VersionPrefix

* Update dependencies from https://github.com/dotnet/arcade build 20250314.5

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25114.5 -> To Version 8.0.0-beta.25164.5

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jenny Bai <v-jennybai@microsoft.com>
* Update dependencies from https://github.com/dotnet/arcade build 20250220.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25114.5 -> To Version 8.0.0-beta.25120.1

* Update Versions.props VersionPrefix

* Update dependencies from https://github.com/dotnet/arcade build 20250314.5

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25114.5 -> To Version 8.0.0-beta.25164.5

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jenny Bai <v-jennybai@microsoft.com>
* Update dependencies from https://github.com/dotnet/arcade build 20250311.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 9.0.0-beta.25111.5 -> To Version 9.0.0-beta.25161.4

* Update Versions.props VersionPrefix

* Update dependencies from https://github.com/dotnet/arcade build 20250314.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 9.0.0-beta.25111.5 -> To Version 9.0.0-beta.25164.2

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jenny Bai <v-jennybai@microsoft.com>
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
* remove release branding for experimental in CI Build

* backport experimental insertion and add servicing branch selection logic

* fix removing versionkind

* bump version

* simplify version suffix selection

* fix comment
changes in the vs17.8 branch which have not been merged yet to vs17.10
* Update dependencies from https://github.com/dotnet/arcade build 20250404.7

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25164.5 -> To Version 8.0.0-beta.25204.7

* Update Versions.props

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jenny Bai <v-jennybai@microsoft.com>
* Update dependencies from https://github.com/dotnet/arcade build 20250404.7

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25111.4 -> To Version 8.0.0-beta.25204.7

* Update Versions.props VersionPrefix

* Update PreReleaseVersionLabel to 'servicing'

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jenny Bai <v-jennybai@microsoft.com>
Co-authored-by: YuliiaKovalova <95473390+YuliiaKovalova@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/arcade build 20250404.5

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 9.0.0-beta.25164.2 -> To Version 9.0.0-beta.25204.5

* Update Versions.props VersionPrefix

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jenny Bai <v-jennybai@microsoft.com>
* Update dependencies from https://github.com/dotnet/arcade build 20250408.7

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25204.7 -> To Version 8.0.0-beta.25208.7

* Update VersionPrefix to 17.8.26

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Gang Wang <v-gaw@microsoft.com>
* Update dependencies from https://github.com/dotnet/arcade build 20250408.7

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25204.7 -> To Version 8.0.0-beta.25208.7

* Update VersionPrefix to 17.10.27

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Gang Wang <v-gaw@microsoft.com>
DownloadFile should not rely on the remote server response headers. Unless the DestinationFileName task parameter is specified - let's just fallback to the request URI - which is as well the publicly documented behavior.
DownloadFile should not rely on the remote server response headers. Unless the DestinationFileName task parameter is specified - let's just fallback to the request URI - which is as well the publicly documented behavior.
…nse headers

DownloadFile should not rely on the remote server response headers. Unless the DestinationFileName task parameter is specified - let's just fallback to the request URI - which is as well the publicly documented behavior

----
#### AI description  (iteration 1)
#### PR Classification
Bug fix to ensure `DownloadFile` does not rely on response headers for file name determination.

#### PR Summary
This pull request modifies the `DownloadFile` task to avoid using response headers for determining the file name, instead relying on the request URI.
- Changes in `src/Tasks/DownloadFile.cs` to use `requestUri` instead of `response` for file name extraction.
- Updated method signature and logic in `TryGetFileName` to handle `requestUri`.
<!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
…nse headers

DownloadFile should not rely on the remote server response headers. Unless the DestinationFileName task parameter is specified - let's just fallback to the request URI - which is as well the publicly documented behavior

----
#### AI description  (iteration 1)
#### PR Classification
Bug fix

#### PR Summary
This pull request updates the `DownloadFile` task to avoid relying on response headers for determining the file name, instead using the request URI.
- Changes in `src/Tasks/DownloadFile.cs` to use `requestUri` instead of `response` for file name determination.
- Modified method signature and logic in `TryGetFileName` to use `requestUri`.
- Updated call to `TryGetFileName` to pass `uri` instead of `response`.
<!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
* Update dependencies from https://github.com/dotnet/arcade build 20250408.7

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25204.7 -> To Version 8.0.0-beta.25208.7

* Update VersionPrefix to 17.11.31

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Gang Wang <v-gaw@microsoft.com>
rainersigwald and others added 3 commits June 6, 2025 09:44
* Update dependencies from https://github.com/dotnet/arcade build 20250602.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 9.0.0-beta.25271.1 -> To Version 9.0.0-beta.25302.2

* Update VersionPrefix to 17.12.39

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Gang Wang <v-gaw@microsoft.com>
@github-actions github-actions bot requested a review from a team as a code owner June 11, 2025 11:26
Conflicts:
	.vsts-dotnet.yml
	azure-pipelines/vs-insertion-experimental.yml
	eng/Versions.props
@AR-May
Copy link
Member

AR-May commented Jun 12, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AR-May
Copy link
Member

AR-May commented Jun 12, 2025

Looked at the error: dotnet-install cannot find the version 9.0.200-preview.0.24603.3 for osx arm64 - this version seems to be missing on the resolved locations.

@AR-May
Copy link
Member

AR-May commented Jun 13, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AR-May
Copy link
Member

AR-May commented Jun 13, 2025

Can not reproduce the failure locally anymore today - maybe it was some outage. Re-running tests.

@AR-May AR-May force-pushed the merge/vs17.12-to-vs17.14 branch from 04806d5 to 5351f21 Compare June 13, 2025 15:10
@AR-May AR-May force-pushed the merge/vs17.12-to-vs17.14 branch from 58abbbb to 6e830f9 Compare June 13, 2025 15:43
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants