[release/9.2] Adding descriptions to all args/options in CLI.#8550
Closed
mitchdenny wants to merge 7 commits intomainfrom
Closed
[release/9.2] Adding descriptions to all args/options in CLI.#8550mitchdenny wants to merge 7 commits intomainfrom
mitchdenny wants to merge 7 commits intomainfrom
Conversation
… access or passwords with emulator (#8503) * Follow up keyvault changes - Pass the IKeyVaultSecretReference to the SecretResolver - Don't add the default keyvault when using the emulator. * Enhance Azure Key Vault integration and add access key authentication support for CosmosDB and other resources * Add the KeyVault resource, but remove it from the model in BeforeStart if the Azure resource is emulated or container in run mode. * Add Microsoft.Extensions.DependencyInjection using statement * Respond to PR feedback --------- Co-authored-by: David Fowler <davidfowl@gmail.com> Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
* Tweak tracing code. * aspire new with prompting. * Template selection. --------- Co-authored-by: Mitch Denny <midenn@microsoft.com>
Using the Azure prefix, as we do this everywhere else. Contributes to #7811 Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Contributes to #7811 Co-authored-by: Sebastien Ros <sebastienros@gmail.com>
* Adding descriptions to all args/options in CLI. * Revert project arg to option. * PR feedback. * Rename resource to integration. * Update src/Aspire.Cli/Commands/RunCommand.cs Co-authored-by: David Fowler <davidfowl@gmail.com> --------- Co-authored-by: David Fowler <davidfowl@gmail.com>
github-actions
bot
added
the
area-integrations
Contributor
There was a problem hiding this comment.
Copilot reviewed 33 out of 34 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- eng/Signing.props: Language not supported
Comments suppressed due to low confidence (1)
src/Aspire.Cli/NuGetPackageCache.cs:11
- The method parameter type was changed from FileInfo to DirectoryInfo. Ensure that all consuming code has been updated accordingly to prevent potential runtime issues.
Task<IEnumerable<NuGetPackage>> GetPackagesAsync(DirectoryInfo workingDirectory, bool prerelease, string? source, CancellationToken cancellationToken);
Comment on lines
+19
to
20
| private BicepOutputReference ContainerAppEnvironmentId => new("AZURE_CONTAINER_APPS_ENVIRONMENT_ID", this); | ||
|
|
There was a problem hiding this comment.
The accessibility of the BicepOutputReference properties was changed from public to private. Verify that this change is intentional since external consumers might rely on these properties.
Suggested change
| private BicepOutputReference ContainerAppEnvironmentId => new("AZURE_CONTAINER_APPS_ENVIRONMENT_ID", this); | |
| public BicepOutputReference ContainerAppEnvironmentId => new("AZURE_CONTAINER_APPS_ENVIRONMENT_ID", this); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8544 to release/9.2
Customer Impact
This PR backports some help text improvements. It also rolls back some other changes around changing the project option to an argument (we decided to backtrack this).
Testing
Manually tested.
Risk
Low.
Regression?
No.