Adding descriptions to all args/options in CLI.#8544
Merged
mitchdenny merged 5 commits intomainfrom Apr 4, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
src/Aspire.Cli/Commands/RunCommand.cs:33
- The short alias '-w' for the '--watch' option may conflict with the '-w' alias used elsewhere. Consider using a unique alias for the watch option to avoid ambiguity.
watchOption.Description = "Start .NET project resources in watch mode.";
src/Aspire.Cli/Commands/RootCommand.cs:26
- The short alias '-w' for the '--wait-for-debugger' option in the root command may lead to conflicts with other commands using '-w'. Verify that the alias is unique within the command context.
waitForDebuggerOption.Description = "Wait for a debugger to attach before executing the command.";
src/Aspire.Cli/Commands/PublishCommand.cs:35
- [nitpick] Using Path.Combine with a single argument returns that argument unchanged, which could be simplified by directly specifying Environment.CurrentDirectory. This change would improve clarity of the default output path.
outputPath.DefaultValueFactory = (result) => Path.Combine(Environment.CurrentDirectory);
davidfowl
reviewed
Apr 4, 2025
davidfowl
approved these changes
Apr 4, 2025
Co-authored-by: David Fowler <davidfowl@gmail.com>
Member
Author
|
/backport to release/9.2 |
Contributor
|
Started backporting to release/9.2: https://github.com/dotnet/aspire/actions/runs/14259414548 |
Contributor
|
@mitchdenny backporting to "release/9.2" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Adding descriptions to all args/options in CLI.
Using index info to reconstruct a base tree...
M src/Aspire.Cli/Commands/NewCommand.cs
M src/Aspire.Cli/Commands/RunCommand.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Aspire.Cli/Commands/RunCommand.cs
CONFLICT (content): Merge conflict in src/Aspire.Cli/Commands/RunCommand.cs
Auto-merging src/Aspire.Cli/Commands/NewCommand.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Adding descriptions to all args/options in CLI.
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Member
Author
|
/backport to release/9.2 |
Contributor
|
Started backporting to release/9.2: https://github.com/dotnet/aspire/actions/runs/14260146125 |
Contributor
|
@mitchdenny backporting to "release/9.2" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Adding descriptions to all args/options in CLI.
Using index info to reconstruct a base tree...
M src/Aspire.Cli/Commands/NewCommand.cs
M src/Aspire.Cli/Commands/RunCommand.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Aspire.Cli/Commands/RunCommand.cs
CONFLICT (content): Merge conflict in src/Aspire.Cli/Commands/RunCommand.cs
Auto-merging src/Aspire.Cli/Commands/NewCommand.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Adding descriptions to all args/options in CLI.
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
mitchdenny
added a commit
that referenced
this pull request
Apr 4, 2025
* Adding descriptions to all args/options in CLI. * Revert project arg to option. * PR feedback. * Rename resource to integration. * Update src/Aspire.Cli/Commands/RunCommand.cs Co-authored-by: David Fowler <davidfowl@gmail.com> --------- Co-authored-by: David Fowler <davidfowl@gmail.com>
mitchdenny
added a commit
that referenced
this pull request
Apr 4, 2025
* Adding descriptions to all args/options in CLI. * Revert project arg to option. * PR feedback. * Rename resource to integration. * Update src/Aspire.Cli/Commands/RunCommand.cs Co-authored-by: David Fowler <davidfowl@gmail.com> --------- Co-authored-by: David Fowler <davidfowl@gmail.com>
danmoseley
pushed a commit
that referenced
this pull request
Apr 4, 2025
* Adding descriptions to all args/options in CLI. * Revert project arg to option. * PR feedback. * Rename resource to integration. * Update src/Aspire.Cli/Commands/RunCommand.cs --------- Co-authored-by: David Fowler <davidfowl@gmail.com> Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI help text pass.
aspire --helpaspire new --helpaspire run --helpaspire add --helpaspire publish --help