fix: Restore context usage display after resume/branch #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After resuming or branching a session, context usage showed 0% because pi-coding-agent--last-usage wasn't populated from the loaded messages. The fix: - Add pi-coding-agent--extract-last-usage helper to find usage from the last non-aborted assistant message in a messages vector - Call this helper in pi-coding-agent--load-session-history after displaying the history, setting pi-coding-agent--last-usage The helper follows the existing pattern from message_end event handling: skips aborted messages (which may have incomplete usage data) and only extracts usage from valid assistant messages. Tests added: - load-session-history-restores-context-usage: Integration test with mock Fortnite tips conversation verifying usage is extracted - load-session-history-skips-aborted-usage: Verifies aborted messages are skipped when extracting usage - extract-last-usage-*: Unit tests for the helper function edge cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After resuming or branching a session, context usage showed 0% because
pi-coding-agent--last-usagewasn't populated from the loaded messages.Root cause:
pi-coding-agent--load-session-historydisplayed messages but didn't extract the usage data from the last assistant message.Fix:
pi-coding-agent--extract-last-usagehelper to find usage from the last non-aborted assistant messageTests: Integration tests with mock Fortnite conversation + unit tests for edge cases (empty, no assistant, aborted messages).