Skip to content

Optimize/relationship extraction #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 9, 2016
Merged

Optimize/relationship extraction #264

merged 8 commits into from
Aug 9, 2016

Conversation

jarekwg
Copy link
Contributor

@jarekwg jarekwg commented Aug 4, 2016 •
edited
Loading

Some options to reduce the number of queries made when using relationships.

Currently the number of db queries made explodes out when either:

  • Including just the primary key as a field in a serializer, without actually "including" it
  • Actually "including" relationships

without prefetching on the viewset's queryset. For complicated models it can be very expensive to defensively prefetch everything every time, so these changes attempt to only fetch them from the db when needed.

  • Added dj110/drf34 tox tests.

Test all pass now, please merge. :)

bor3ham and others added 8 commits August 4, 2016 12:56
@bor3ham @jarekwg
Try to fetch the pk field from instance for pk related fields.
3886878 
Rather than making another query to fetch the object for every result.
@bor3ham @jarekwg
Viewset wrapper that auto prefetches related fields.
d34b797
@bor3ham @jarekwg
Get included resources as util
ccd2681
@bor3ham @jarekwg
Now works with nested relationship prefetching.
d3bb2b2 
The validation here is awkward (following the relationships through
the model fields), I couldn't find a better way to ensure the
included args exist for a django prefetch rather than erroring out.
@jarekwg
Missing None
e0c6cc5
@jarekwg
Don't break old tests
5cb9e21
@jarekwg
Test againts dj110/drf34
b2ec862
@jarekwg
Pre-dj19 compat
04a100c
@bor3ham bor3ham mentioned this pull request Aug 4, 2016
Closed
@jerel jerel merged commit 04a100c into django-json-api:develop Aug 9, 2016
@jarekwg jarekwg deleted the optimize/relationship-extraction branch October 19, 2018 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jarekwg @jerel @bor3ham