Optimize/relationship extraction #243
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than making another query to fetch the object for every result.
The validation here is awkward (following the relationships through the model fields), I couldn't find a better way to ensure the included args exist for a django prefetch rather than erroring out.
|
Rebased and patched over at: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some options to reduce the number of queries made when using relationships.
Currently the number of db queries made explodes out when either:
without prefetching on the viewset's queryset. For complicated models it can be very expensive to defensively prefetch everything every time, so these changes attempt to only fetch them from the db when needed.