Merged
Conversation
…pple#1051) Run = Create + Start 1) Mount source points to a valid directory - Run and Create + Start both correctly create the container with mount. 2) Mount source points to a file - Run fails bootstrapping the container, thus container not created. - Create creates the container, but Start fails bootstrapping, removing the container. (Thus, both are the same.) 3) Mount source deleted or replaced to file after container created - Start throw errors but do not delete the container.
…1063) ## Type of Change - [x] New feature - [x] Breaking change ## Motivation and Context This PR changes the behavior of the `defaultArguments` field in the service plugin config. Previously, `defaultArguments` was functioning as a way to indicate how to start a plugin in the event that the plugin is loaded at boot (such as for the `container-core-images plugin`). However, we now follow a convention where all plugins have a "start" command that is used when launching the plugin, so this `defaultArguments` field wasn't really providing much. Instead, there are use cases where we may want to set default values to pass to a plugin. This PR repurposes the `defaultArguments` field for those use cases. As an example use case, there are scenarios where someone may want to use the AllocationOnlyVmnetNetwork even when running on macOS 26+. This PR adds the ability to pass in a command line option to the vmnet network plugin to specify that request. Combined with the `defaultArguments` plugin config change, a user may choose to set that field to ["--variant", "allocationOnly"] in the `container-network-vmnet-config.json` to use AllocationOnlyVmnetNetwork by default for all networks. ## Testing - [x] Tested locally
… only plugin (apple#1057) ## Type of Change - [x] Bug fix ## Motivation and Context This PR changes the behavior of the Allocation Only vmnet network plugin to use the default subnet in the fallback case if no subnet was specified in the network configuration. This matches the behavior of `ReservedVmnetNetwork`. ## Testing - [x] Tested locally
- Facilitates apple#507, apple#642. - Plumb logger with logger option access into every command. - StderrLogHandler allows logging to be enhanced for ANSI color mode for log levels, JSONL log output, replacing `--debug` with `--level level`. - Global logger is now just an Application.swift fileprivate only used for initial args processing. - Log with timestamp at debug and trace level. - Metadata output is crude at present; we can refine this in a follow-up.
- Runner fleet is on 26.3 now. - Integration tests started flaking and it appears that we've been misconfiguring/not configuring proxy variables where we needed to be and it finally caught up with us. Workflow now adds appropriate exclusions for host-to-container and container-to-container network requests so they aren't all rammed through the proxy.
- Relates to apple#642. - Each image carries it own error message (allows for different error types per image) - Stdout/stderr support - Use of the new `StderrLogHandler`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
[Why is this change needed?]
Testing