Use configuration subnet and fallback to default subnet in allocation only plugin#1057
Merged
katiewasnothere merged 1 commit intoapple:mainfrom Jan 20, 2026
Conversation
jglogan
reviewed
Jan 16, 2026
Sources/Services/ContainerNetworkService/Server/AllocationOnlyVmnetNetwork.swift
Outdated
Show resolved
Hide resolved
katiewasnothere
force-pushed
the
use_config_subet_allocation_only
branch
from
99b254b to
f2f1b61
Compare
jglogan
approved these changes
Jan 16, 2026
katiewasnothere
force-pushed
the
use_config_subet_allocation_only
branch
2 times, most recently
from
e5f2d02 to
87a9651
Compare
katiewasnothere
force-pushed
the
use_config_subet_allocation_only
branch
from
87a9651 to
7aabae1
Compare
saehejkang
pushed a commit
to saehejkang/container
that referenced
this pull request
Jan 23, 2026
… only plugin (apple#1057) ## Type of Change - [x] Bug fix ## Motivation and Context This PR changes the behavior of the Allocation Only vmnet network plugin to use the default subnet in the fallback case if no subnet was specified in the network configuration. This matches the behavior of `ReservedVmnetNetwork`. ## Testing - [x] Tested locally
saehejkang
pushed a commit
to saehejkang/container
that referenced
this pull request
Jan 27, 2026
… only plugin (apple#1057) ## Type of Change - [x] Bug fix ## Motivation and Context This PR changes the behavior of the Allocation Only vmnet network plugin to use the default subnet in the fallback case if no subnet was specified in the network configuration. This matches the behavior of `ReservedVmnetNetwork`. ## Testing - [x] Tested locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
This PR changes the behavior of the Allocation Only vmnet network plugin to use the default subnet in the fallback case if no subnet was specified in the network configuration. This matches the behavior of
ReservedVmnetNetwork.Testing