Tweak IDE help text and alignment #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we used an empty cell which created a gap on the right but that caused the IDE dropdown to change sizes based on its content. I removed `indent` and added an empty border so we get consistent padding on both sides although I have no idea if this is the idiomatic way to do this.
Just to help make it clear the checkbox applies to when the connect button is pressed and not the table below.
To help make it clear it applies to the connect action and not to whatever happens to be displayed below in the table.
UI moving around can be confusing.
johnstcn
approved these changes
Mar 29, 2023
| registerStep(CoderLocateRemoteProjectStepView { | ||
| nextButton.isVisible = false | ||
| }) | ||
| registerStep(CoderLocateRemoteProjectStepView { nextButton.isEnabled = it }) |
There was a problem hiding this comment.
review: In Kotlin, you can just say it in a lambda with one parameter. TIL.
src/main/kotlin/com/coder/gateway/views/steps/CoderLocateRemoteProjectStepView.kt
Outdated
Show resolved
Hide resolved
code-asher
force-pushed
the
ide-help-text-and-alignment
branch
from
7689fb5 to
12f3956
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a break from connection issues...
This fixes some alignment issues and changes the help text based on whether the IDE is already installed.
Closes #167