Skip to content

Migration to SQL and fixes#629

Merged
carkod merged 7 commits intomasterfrom
sql-fixes
Dec 1, 2024
Merged

Migration to SQL and fixes#629
carkod merged 7 commits intomasterfrom
sql-fixes

Conversation

@carkod
Copy link
Owner

@carkod carkod commented Nov 19, 2024

Part of #606

@gitguardian
Copy link

gitguardian bot commented Nov 19, 2024

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14478150 Triggered Generic Password 615daca api/database/api_db.py View secret
14478150 Triggered Generic Password 615daca .github/workflows/pr.yml View secret
14478150 Triggered Generic Password 615daca api/database/api_db.py View secret
14478150 Triggered Generic Password 615daca .github/workflows/pr.yml View secret
14478150 Triggered Generic Password 615daca .github/workflows/pr.yml View secret
14478150 Triggered Generic Password 615daca .github/workflows/pr.yml View secret
14478150 Triggered Generic Password 14f7d94 .github/workflows/pr.yml View secret
14478150 Triggered Generic Password 14f7d94 .github/workflows/pr.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@carkod carkod changed the title Sql fixes SQL fixes Nov 22, 2024
@carkod carkod force-pushed the sql-fixes branch 8 times, most recently from 7f887b0 to ed9345f Compare November 23, 2024 19:08
@carkod carkod changed the title SQL fixes Migration to SQL and fixes Nov 23, 2024
@carkod carkod force-pushed the sql-fixes branch 13 times, most recently from 23a0665 to 156a2c2 Compare November 24, 2024 14:24
@carkod carkod force-pushed the sql-fixes branch 7 times, most recently from 9624fde to 98e7607 Compare November 30, 2024 22:00
@carkod carkod force-pushed the sql-fixes branch 16 times, most recently from 1f923af to faabb1c Compare December 1, 2024 19:12
This is to separate integration tests from unit tests. The reason is that database operations often update things like datetime fields, which change everytime if we include them in unit tests. Therefore, unit tests are performed independenty of database operations (therefore mocked) and integration will be tested using github actions through the database init function.
@carkod carkod merged commit de7c205 into master Dec 1, 2024
@carkod carkod deleted the sql-fixes branch December 1, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant