CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9 by yadvr · Pull Request #2211 · apache/cloudstack

yadvr · 2017-07-28T19:25:28Z

Outstanding tasks (feel free to add more):

Pinging for review and additional help with changes @wido @swill and others
This branch is pushed on ASF remote and allows for all committers to contribute changes directly, feel free to push fixes as separate commits, thanks.

Systemvmtemplate built from this branch are available here for testing: http://hydra.yadav.xyz/debian9/ (temporarily hosted until this branch is merged).

New SystemVM prompt showcasing the systemvmtemplate version and cloudmonkey ascii art:

wido · 2017-08-08T11:50:27Z

I am trying to review this one, but obviously testing it will be difficult. Can you tell me a bit on what your are still stuck on?

Building it with Veewee, but how to proceed from there? Just put it into a 4.10 cloud and test with it? Keep testing and testing?

yadvr · 2017-08-08T11:54:40Z

@wido I got the build system and patching via socket (kvm) work. Currently, I'm stuck on making the various init.d script to work under systemd. I would say build the systemvmtemplate, and deploy a fresh KVM based environment and fix cloud-early-config and other init.d scripts to work with systemd. Next, step would be to do the same for other hypervisors. Feel free to push to this branch on the asf remote as separate commits (don't squash yet).

For reference, see the checklist above.

wido · 2017-08-08T11:56:32Z

Ok! I will build a 4.10 cloud and try to build the systemVM. Currently stuck with Veewee though. Systemd should be doable, I have used it a lot and have a team of systemd people around me.

wido@wido-laptop:~/repos/cloudstack/tools/appliance$ veewee vbox build systemvmtemplate
/usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- net/scp (LoadError)
	from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /var/lib/gems/2.3.0/gems/veewee-0.4.5.1/lib/veewee/provider/core/helper/ssh.rb:3:in `'
	from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /var/lib/gems/2.3.0/gems/veewee-0.4.5.1/lib/veewee/provider/core/box.rb:2:in `'
	from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /var/lib/gems/2.3.0/gems/veewee-0.4.5.1/lib/veewee/provider/virtualbox/box.rb:1:in `'
	from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /var/lib/gems/2.3.0/gems/veewee-0.4.5.1/lib/veewee/provider/virtualbox/provider.rb:2:in `'
	from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /var/lib/gems/2.3.0/gems/veewee-0.4.5.1/lib/veewee/providers.rb:14:in `[]'
	from /var/lib/gems/2.3.0/gems/veewee-0.4.5.1/lib/veewee/environment.rb:225:in `get_box'
	from /var/lib/gems/2.3.0/gems/veewee-0.4.5.1/lib/veewee/command/vbox.rb:22:in `build'
	from /var/lib/gems/2.3.0/gems/thor-0.19.4/lib/thor/command.rb:27:in `run'
	from /var/lib/gems/2.3.0/gems/thor-0.19.4/lib/thor/invocation.rb:126:in `invoke_command'
	from /var/lib/gems/2.3.0/gems/thor-0.19.4/lib/thor.rb:369:in `dispatch'
	from /var/lib/gems/2.3.0/gems/thor-0.19.4/lib/thor/invocation.rb:115:in `invoke'
	from /var/lib/gems/2.3.0/gems/thor-0.19.4/lib/thor.rb:242:in `block in subcommand'
	from /var/lib/gems/2.3.0/gems/thor-0.19.4/lib/thor/command.rb:27:in `run'
	from /var/lib/gems/2.3.0/gems/thor-0.19.4/lib/thor/invocation.rb:126:in `invoke_command'
	from /var/lib/gems/2.3.0/gems/thor-0.19.4/lib/thor.rb:369:in `dispatch'
	from /var/lib/gems/2.3.0/gems/thor-0.19.4/lib/thor/base.rb:444:in `start'
	from /var/lib/gems/2.3.0/gems/veewee-0.4.5.1/bin/veewee:24:in `'
	from /usr/local/bin/veewee:22:in `load'
	from /usr/local/bin/veewee:22:in `'
wido@wido-laptop:~/repos/cloudstack/tools/appliance$

yadvr · 2017-08-08T11:57:09Z

@wido do a pull --rebase I've pushed latest branch rebased on master. cd to the folder, and do a bundle install, you may need to update bundler with gem install bundler first. Read the docs to setup your env: https://github.com/apache/cloudstack/blob/master/tools/appliance/README.md to allow building of systemvmtemplate using virtualbox, update this in case of any changes/issues.

pdion891 · 2017-08-08T13:25:42Z

@wido I think weevee only work with ruby 1.9 so you need to downgrade your ruby version.

yadvr · 2017-08-08T14:24:39Z

@pdion891 no, it works with ruby 2.3 -- I had upgraded the build system couple of months ago. See the rvmrc at tools/appliance and README for details. /cc @wido

wido · 2017-08-10T11:28:51Z

I eventually used the build.sh script in tools/appliance and got a img.raw

On my existing test cluster I manually overwrite the QCOW2 template on SS and then re-deployed the Secondary Storage VM.

It's 'running' now but the Agent isn't starting yet, which is a systemd thing. Looking into that.

wido · 2017-08-10T11:37:12Z

tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh

-  chkconfig cloud-passwd-srvr off
-  chkconfig --add cloud
-  chkconfig cloud off
+  cat > /lib/systemd/system/cloud-early-config.service << EOF


Shouldn't we put these in /etc/systemd/system as they are kind of custom?

We can do that, but isn't the files in /etc/systemd/system/multi-user.target.wants symlinked to /lib/systemd? I'm open to changes as long as the stuff works.

No, it isn't. But we'd have to look into that. I'll debug a bit further and push a few commits to the branch without squashing anything

@wido thanks, please feel free to do so.

wido · 2017-08-10T11:39:44Z

tools/appliance/definitions/systemvmtemplate/configure_networking.sh

+# The primary network interface
+auto eth0
+iface eth0 inet dhcp
+pre-up sleep 2


Why do we sleep here? Is that really needed?

Historic reasons, I've no idea. I simply moved the code from here: https://github.com/apache/cloudstack/blob/master/tools/appliance/definitions/systemvmtemplate/configure_networking.sh#L28

wido · 2017-08-10T11:40:30Z

tools/appliance/definitions/systemvmtemplate/configure_login.sh

  mkdir -p /home/cloud/.ssh
  chmod 700 /home/cloud/.ssh
  echo "cloud:`openssl rand -base64 32`" | chpasswd
+  echo "root:password" | chpasswd


Does this force the password for root to 'password'? It seems it does

Yes, this is ensure all systemvmtemplates have this default credentials (this is what the current systemvmtemplates use as well). In production env, you can set system.vm.random.password to true which then uses system.vm.password to get the password randomly set when mgmt server is initialized.

yadvr · 2017-08-10T11:52:46Z

@wido yes, I got it so far as to get serial console (virsh console <domain> works) and ssh work. However, when you restart the systemvm (ssvm/cpvm/vr etc) or stop+start the systemvm, it fails ssh login. You're right, something's not right with patching and/or systemd.

Use a holder class to pass buffers, fixes potential leak. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

- Fixes timezone issue where dates show up as nvalid in UI - Introduces new event timeline listing/filtering of events - Several UI improvements to add columns in list views - Bulk operations support in instance list view to shutdown and destroy multiple-selected VMs (limitation: after operation, redundant entries may show up in the list view, refreshing VM list view fixes that) - Align table thead/tbody to avoid splitting of tables Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

- Removes old/dead files - Refactors file path/location, backward compatible to filepaths in systemvm.isoa - Fixes failures around apache2

- Fixes strongswan/ipsec, l2tpd and pppd configs - Uses auto=route in ipsec configs - Fixes road-warrior setup - Fixes site-to-site VPN with automatic connection configuration - Fixes vpc_vpn tests Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

@swill

This ports the S2S config test by @swill from #2190 with additional changes to make robust and environment agnostic. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

@remibergsma

This ports PR #1470 by @remibergsma. Make the generated json files unique to prevent concurrency issues: The json files now have UUIDs to prevent them from getting overwritten before they've been executed. Prevents config to be pushed to the wrong router. 2016-02-25 18:32:23,797 DEBUG [c.c.a.t.Request] (AgentManager-Handler-1:null) (logid:) Seq 2-4684025087442026584: Processing: { Ans: , MgmtId: 90520732674657, via: 2, Ver: v1, Flags: 10, [{"com.cloud.agent.api.routing.GroupA nswer":{"results":["null - success: null","null - success: [INFO] update_config.py :: Processing incoming file => vm_dhcp_entry.json.4ea45061-2efb-4467-8eaa-db3d77fb0a7b\n[INFO] Processing JSON file vm_dhcp_entry.json.4ea4506 1-2efb-4467-8eaa-db3d77fb0a7b\n"],"result":true,"wait":0}}] } On the router: 2016-02-25 18:32:23,416 merge.py __moveFile:298 Processed file written to /var/cache/cloud/processed/vm_dhcp_entry.json.4ea45061-2efb-4467-8eaa-db3d77fb0a7b.gz Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

- Refactors and simplifies systemvm codebase file structures keeping the same resultant systemvm.iso packaging - Password server systemd script and new postinit script that runs before sshd starts - Fixes to keepalived and conntrackd config to make rVRs work again - New /etc/issue featuring ascii based cloudmonkey logo/message and systemvmtemplate version - SystemVM python codebase linted and tested. Added pylint/pep to Travis. - iptables re-application fixes for non-VR systemvms. - SystemVM template build fixes. - Default secondary storage vm service offering boosted to have 2vCPUs and RAM equal to console proxy. - Fixes to several marvin based smoke tests, especially rVR related tests. rVR tests to consider 3*advert_int+skew timeout before status is checked. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

- Several systemvmtemplate optimizations - Uses new macchinina template for running smoke tests - Switch to latest Debian 9.3.0 release for systemvmtemplate - Introduce a new `get_test_template` that uses tiny test template such as macchinina as defined test_data.py - rVR related fixes and improvements Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

On XenServer, both redundant router's vifs were getting deleted when any PF rule is removed from any of the acquired public IPs. This fix ensures that lastIp is set to `false` when processed by hypervisor resources to avoid removing of VIFs when VPCs have any source nat IP. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This adds the `net-tools` dependency on CentOS cloudstack-agent rpms. This will provide ifconfig, route and other tools that may be used by CloudStack scripts and utilities. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Resize for VMware root disk should only be performed during VM start when vmware.create.full.clone is true i.e. the disk chain length is one. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This fixes test failures around VMware with the new systemvmtemplate. In addition: - Does not skip rVR related test cases for VMware - Removes rc.local - Processes unprocessed cmd_line.json - Fixed NPEs around VMware tests/code - On VMware, use udevadm to reconfigure nic/mac address than rebooting - Fix proper acpi shutdown script for faster systemvm shutdowns - Give at least 256MB of swap for VRs to avoid OOM on VMware - Fixes smoke tests for environment related failures Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

In default/fresh installations, the guest os type for systemvms with id=15 or Debian 5 (32-bit) can cause memory allocation issues to guest. Using Other Linux 64-bit as guest OS systemvms get all the allocated RAM. This avoids OOM related kernel panics for certain VRs such as rVRs, lbvm etc. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

- This migrates the current systemvmtemplate build system from veewee/virtualbox to packer and qemu based. - This also introduces and updates a CentOS7 built-in template. - Remove old appliance build scripts and files. - Adds iftop package (CLOUDSTACK-9785) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This moves the systevmtemplate migration logic from previous upgrade path to 4.10.0.0->4.11.0.0 upgrade path. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This fixes incorrect total host memory in listHosts and related host responses, regression introduced in #2120. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

In a VMware 55u3 environment it was found that CPVM and SSVM would get the same public IP. After another investigative review of fetchNewPublicIp method, it was found that it would always pick up the first IP from the sql query list/result. The cause was found to be that with the new changes no table/row locks are done and first item is used without looping through the list of available free IPs. The previously implementation method that put IP address in allocating state did not check that it was a free IP. In this refactoring/fix, the first free IP is first marked as allocating and if assign is requested that is changed into Allocated state. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

blueorangutan · 2017-12-23T10:15:40Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1466

@rafaelweingartner

This includes test related fixes and code review fixes based on reviews from @rafaelweingartner, @marcaurele, @wido and @DaanHoogland. This also includes VMware disk-resize limitation bug fix based on comments from @sateesh-chodapuneedi and @priyankparihar. This also includes the final changes to systemvmtemplate and fixes to code based on issues found via test failures. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yvsubhash · 2017-12-23T19:15:04Z

server/src/com/cloud/network/IpAddressManagerImpl.java

+                        final IPAddressVO userIp = _ipAddressDao.findById(addr.getId());
+                        if (userIp.getState() == IpAddress.State.Free) {
+                            addr.setState(IpAddress.State.Allocating);
+                            if (_ipAddressDao.update(addr.getId(), addr)) {


@rhtyd unlike previous approach, now it seems to be doing an extra update operation to DB when assign is true, can we avoid that?

The current regression fix is a two step process where IPs are first marked allocating and then marked allocated if assign is true, it's because ips in both free and allocating state can be allocated. ~~Do you propose we simply mark free ips to allocated in the loop if assign is true?~~ @yvsubhash if you can come up with further improvements/enhancements, please send a new PR, thanks.

blueorangutan · 2017-12-23T19:58:43Z

Trillian test result (tid-1882)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34329 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1882-kvm-centos7.zip
Smoke tests completed. 66 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

✅ 🎉 all pass!

borisstoyanov · 2017-12-23T21:03:38Z

@rhtyd ^^ 0 failures, haven't seen this for a while :) 🥇

blueorangutan · 2017-12-23T22:11:41Z

Trillian test result (tid-1886)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41372 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1886-vmware-55u3.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 66 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

✅ 🎉 all pass!

blueorangutan · 2017-12-23T23:18:08Z

Trillian test result (tid-1890)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41495 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1890-xenserver-65sp1.zip
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Smoke tests completed. 65 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_09_destroy_ssvm	`Failure`	136.34	test_ssvm.py

When the agent keystore is setup for cpvm/ssvm it restarts the cloud process so if the ssh happens around this time, the process may appear dead as the ssvm-check.sh does not systemctl status but uses ps -eaf | grep java.

Re-ran tests and it passed:

Test List secondary storage VMs ... === TestName: test_01_list_sec_storage_vm | Status : SUCCESS ===
ok
Test List console proxy VMs ... === TestName: test_02_list_cpvm_vm | Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS ===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS ===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS ===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS ===
ok
Test NFS Version on Secondary Storage mounted properly on SSVM ... SKIP: No NFS version provided in test data

Ran 11 tests in 624.154s
OK (SKIP=1)

✅ 🎉 all pass!

blueorangutan · 2017-12-23T23:34:40Z

Trillian test result (tid-1889)
Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44107 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1889-vmware-65.zip
Smoke tests completed. 66 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

✅ 🎉 all pass!

yadvr · 2017-12-24T03:50:49Z

Thanks @borisstoyanov :)
Based on the last smoketests run we've 0 errors for KVM (centos7) and VMware (5.5u3 with svs and 6.5u1 with dvs). The one ssvm test case failed for XenServer 65sp1 passed on re-run and no blockers are seen.

I'll merge the PR now and post-merge I'll kick smoke and component tests. Some component tests have been fixed in #2344 and will work with @borisstoyanov and others to further stabilize tests and master.

blueorangutan · 2017-12-25T08:56:07Z

Trillian test result (tid-1904)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 82207 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1904-kvm-centos7.zip
Test completed. 127 look ok, 27 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
runTest	`Error`	0.00	test_affinity_groups.py
test_01_data_persistency_root_disk	`Error`	810.72	test_blocker_bugs.py
test_03_reuse_template_name	`Error`	416.61	test_blocker_bugs.py
test_browser_upload_template_incomplete	`Failure`	0.05	test_browse_templates2.py
test_01_Browser_template_Life_cycle_tpath	`Failure`	0.01	test_browse_templates.py
test_02_SSVM_Life_Cycle_With_Browser_Template_TPath	`Failure`	100.35	test_browse_templates.py
test_04_Browser_template_ResetVM_With_Deleted_Template	`Failure`	0.01	test_browse_templates.py
test_05_Browser_Upload_Template_with_all_API_parameters	`Failure`	0.01	test_browse_templates.py
test_06_Browser_Upload_template_resource_limits	`Failure`	0.04	test_browse_templates.py
test_07_Browser_Upload_template_secondary_storage_resource_limits	`Failure`	0.03	test_browse_templates.py
test_08_Browser_Upload_template_resource_limits_after_deletion	`Failure`	0.02	test_browse_templates.py
test_09_Browser_Upload_Volume_secondary_storage_resource_limits_after_deletion	`Failure`	0.01	test_browse_templates.py
test_browser_upload_template_incomplete	`Failure`	0.01	test_browse_templates.py
ContextSuite context=TestBrowseUploadVolume>:setup	`Error`	0.00	test_browse_volumes.py
test_deployvm_multinic	`Error`	0.47	test_deploy_vm_userdata_multi_nic.py
ContextSuite context=TestDynamicServiceOffering>:setup	`Error`	41.07	test_dynamic_compute_offering.py
test_01_list_vpncustomergateways_pagination	`Error`	5.12	test_escalations_vpncustomergateways.py
test_02_update_vpncustomergateways	`Error`	5.08	test_escalations_vpncustomergateways.py
test_04_host_ha_vmactivity_check	`Error`	839.08	test_host_ha.py
test_01_host_ha_with_nfs_storagepool_with_vm	`Error`	63.19	test_host.py
ContextSuite context=TestXDCCPInterop>:setup	`Error`	0.00	test_interop_xd_ccp.py
test_02_migrate_volume_to_maintenance_pool	`Failure`	0.07	test_migrate_vol_to_maintained_pool.py
test_02_Overcommit_factor	`Error`	861.95	test_overcommit.py
test_01_template_usage	`Error`	666.03	test_project_usage.py
test_create_template_snapshot_1_root_domain_admin	`Failure`	141.51	test_ps_limits.py
test_create_template_snapshot_2_child_domain_admin	`Failure`	141.91	test_ps_limits.py
test_attach_volume_exceeding_primary_limits	`Error`	91.14	test_ps_resource_limits_volume.py
ContextSuite context=TestResetSSHKeyUserRights>:setup	`Error`	0.00	test_reset_ssh_keypair.py
test_01_authorizeIngressRule	`Failure`	851.27	test_security_groups.py
test_01_dhcpOnlyRouter	`Error`	719.60	test_security_groups.py
test_01_authorizeIngressRule_AfterDeployVM	`Failure`	792.00	test_security_groups.py
test_02_revokeIngressRule_AfterDeployVM	`Failure`	786.98	test_security_groups.py
test_03_stopStartVM_verifyIngressAccess	`Failure`	736.70	test_security_groups.py
test_ingress_rules_specific_IP_set	`Failure`	1021.53	test_security_groups.py
test_ingress_rules_specific_IP_set_non_def_sec_group	`Error`	5.09	test_security_groups.py
test_01_revokeIngressRule	`Failure`	735.85	test_security_groups.py
test_01_deployVMWithUserData	`Failure`	735.92	test_security_groups.py
test_01_volume_from_snapshot	`Failure`	842.45	test_snapshots.py
test_03_snapshot_detachedDisk	`Failure`	817.41	test_snapshots.py
test_01_VRServiceFailureAlerting	`Error`	724.96	test_VirtualRouter_alerts.py
ContextSuite context=TestVMPasswordEnabled>:setup	`Error`	0.00	test_vm_passwdenabled.py
test_es_1863_register_template_s3_domain_admin_user	`Error`	0.57	test_bugs.py
test_01_op_host_capacity_disable_cluster	`Failure`	0.02	test_escalations_hosts.py
test_02_op_host_capacity_disable_pod	`Failure`	0.02	test_escalations_hosts.py
test_03_op_host_capacity_disable_zone	`Failure`	0.02	test_escalations_hosts.py
test_04_disable_host_unmanage_cluster_check_hosts_status	`Failure`	125.26	test_escalations_hosts.py
test_02_template_permissions	`Error`	99.78	test_escalation_templates.py
ContextSuite context=TestlistTemplates>:teardown	`Error`	110.23	test_escalation_templates.py
test_01_deploy_vm_with_explicit_dedication	`Error`	15.60	test_explicit_dedication.py
test_ha_with_storage_maintenance	`Error`	5.67	test_ha_pool_maintenance.py
test_ha_with_storage_maintenance	`Error`	5.68	test_ha_pool_maintenance.py
ContextSuite context=TestSystemVmLocalStorage>:setup	`Error`	0.00	test_zone_level_local_storage_setting.py

fmaximus · 2018-01-09T14:14:45Z

Seems like we hit https://issues.apache.org/jira/browse/CLOUDSTACK-9749 again.
Password server is running on internal LB VM, while it should only run on routers.

yadvr · 2018-01-09T14:38:30Z

@fmaximus thanks for sharing, can you explore a fix and perhaps help submit a PR on this basing the fix in the python script than the shell/setup scripts:
https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/cs/CsAddress.py#L569

yadvr requested review from remibergsma, swill and wido July 28, 2017 19:25

yadvr mentioned this pull request Jul 28, 2017

CLOUDSTACK-10013: Migrate to Debian9 for systemvmtemplate #2198

Closed

yadvr added component:networking component:systemd component:systemvm-template status:work-in-progress labels Jul 28, 2017

asfgit force-pushed the debian9-systemvmtemplate branch 8 times, most recently from 5f3cb74 to 5844597 Compare July 29, 2017 12:52

apache deleted a comment from blueorangutan Jul 29, 2017

asfgit force-pushed the debian9-systemvmtemplate branch from 5844597 to 70d84c9 Compare July 29, 2017 16:57

apache deleted a comment from blueorangutan Jul 29, 2017

asfgit force-pushed the debian9-systemvmtemplate branch from 70d84c9 to 6c8fbc9 Compare August 8, 2017 11:57

wido reviewed Aug 10, 2017

View reviewed changes

yadvr and others added 17 commits December 23, 2017 09:22

CLOUDSTACK-9348: Improve Nio SSH handshake buffers

d0005d8

Use a holder class to pass buffers, fixes potential leak. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

CLOUDSTACK-10013: SystemVM.iso refactoring and cleanups

9aa7d4e

- Removes old/dead files - Refactors file path/location, backward compatible to filepaths in systemvm.isoa - Fixes failures around apache2

CLOUDSTACK-10010: Port marvin test from #2190 by @swill

d943eb9

This ports the S2S config test by @swill from #2190 with additional changes to make robust and environment agnostic. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

CLOUDSTACK-9953: Resize root disk for VMware when full clone is enabled

ce33032

Resize for VMware root disk should only be performed during VM start when vmware.create.full.clone is true i.e. the disk chain length is one. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

CLOUDSTACK-10013: Add systemvm 4.11 migration in 4.10->4.11 upgrade path

0b43cd9

This moves the systevmtemplate migration logic from previous upgrade path to 4.10.0.0->4.11.0.0 upgrade path. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

CLOUDSTACK-10001: Fix incorrect total host memory in responses

68b3b44

This fixes incorrect total host memory in listHosts and related host responses, regression introduced in #2120. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yvsubhash reviewed Dec 23, 2017

View reviewed changes

yadvr mentioned this pull request Jan 6, 2018

Refactor test_vpc_vpn, add test for multiple VPNs #1355

Closed

Conversation

yadvr commented Jul 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wido commented Aug 8, 2017

Uh oh!

yadvr commented Aug 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wido commented Aug 8, 2017

Uh oh!

yadvr commented Aug 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pdion891 commented Aug 8, 2017

Uh oh!

yadvr commented Aug 8, 2017

Uh oh!

wido commented Aug 10, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yadvr commented Aug 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueorangutan commented Dec 23, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yadvr Dec 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Dec 23, 2017 • edited by yadvr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

borisstoyanov commented Dec 23, 2017

Uh oh!

blueorangutan commented Dec 23, 2017 • edited by yadvr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueorangutan commented Dec 23, 2017 • edited by yadvr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueorangutan commented Dec 23, 2017 • edited by yadvr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yadvr commented Dec 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueorangutan commented Dec 25, 2017

Uh oh!

fmaximus commented Jan 9, 2018

Uh oh!

yadvr commented Jan 9, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

yadvr commented Jul 28, 2017 •

edited

Loading

yadvr commented Aug 8, 2017 •

edited

Loading

yadvr commented Aug 8, 2017 •

edited

Loading

yadvr commented Aug 10, 2017 •

edited

Loading

yadvr Dec 24, 2017 •

edited

Loading

blueorangutan commented Dec 23, 2017 •

edited by yadvr

Loading

blueorangutan commented Dec 23, 2017 •

edited by yadvr

Loading

blueorangutan commented Dec 23, 2017 •

edited by yadvr

Loading

blueorangutan commented Dec 23, 2017 •

edited by yadvr

Loading

yadvr commented Dec 24, 2017 •

edited

Loading