Command route not available on CentOS 7

[alemorvan]

Hi guys,

The command route is not available on a fresh install of CentOS 7.
This one should be replace by ip route.

Command route make crash cloudstack-setup-agent on CentOS 7.
Another way is to make the net-tools paquet as dependencies of cloudstack-setup-agent.

[jburwell]

@lmrv does this defect impact 4.9 as well? If so, could you please re-target this PR to the 4.9 branch?

Also, why is there a merge commit in this PR?

[jburwell]

@lmrv I would like to include this PR in the upcoming 4.8.2.0, 4.9.1.0, and 4.10.0.0 releases for which we plan to cut RCs on 25 Sept 2016. In order to merge it, the following items need to be addressed:

• Create a JIRA ticket for this bug and reference it in the commit message
• Squash commits
• Investigate/fix Jenkins build failures
• Re-target this PR to the 4.8 branch. It will be forward merged to 4.9 and master as part of the PR merge

[alemorvan]

Hi John,
I just create the JIRA ISSUE :
https://issues.apache.org/jira/browse/CLOUDSTACK-9501

[alemorvan]

I will need your help John.
Ok for JIRA ticket but I don't know how to squash my commits, how to retarget my pull request.
I am not confortable at all with github.
And for Jenkis, no more skill...

[resmo]

speaking about things not available per default on CentOS 7 --> ifconfig. Found 1 or 2 of these as well.

[alemorvan]

Hi Resmo,

Correct. Most net commands are now replace by the ip command.

ip link set dev eth0 up
ip route
ip add
etc.

In our case, the ifconfig is not used by cloudstack-setup-agent, but the route one is. This cause the setup-agent to crash if route is not installed before.

Making the change can help deployment on CentOS7 and should work on CentOS6 out of the box.

Lots of changes have been made regardings the net on CentOS7. You should now use nmtui in replacement of the system-config-network-tui by example.

Regards.

[yadvr]

@lmrv can you squash your changes and rebase against latest master, I can help run tests on your PR.

[yadvr]

@lmrv ping

[yadvr]

@lmrv ping, can you squash your changes, get a JIRA ticket for this and use the JIRA id in the git summary, thanks.

[yadvr]

@lmrv ping

[yadvr]

I'll introduce net-tools as a dependency for centos7/cloudstack-agent, as there may be other commands/places where router/ifconfig maybe in use.

[yadvr]

Thanks @lmrv I've ported your patch to #2211 for inclusion crediting the commit to your name/email. I'll close this PR now.