Fix: Theme.json application of custom root selector for styles#5944
Closed
aaronrobertshaw wants to merge 1 commit intoWordPress:trunkfrom
Closed
Fix: Theme.json application of custom root selector for styles#5944aaronrobertshaw wants to merge 1 commit intoWordPress:trunkfrom
aaronrobertshaw wants to merge 1 commit intoWordPress:trunkfrom
Conversation
This was referenced Jan 25, 2024
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This comment was marked as spam.
This comment was marked as spam.
| } | ||
| if ( false !== $root_style_key ) { | ||
| $setting_nodes[ $root_style_key ]['selector'] = $options['root_selector']; | ||
| $style_nodes[ $root_style_key ]['selector'] = $options['root_selector']; |
Member
There was a problem hiding this comment.
Does this bug exist in the previous version that we addressed in this fix?
Author
There was a problem hiding this comment.
I'm sorry, I'm not following that question, could you please rephrase it for me?
If you mean did this bug exist in prior versions of WP, then yes. It looks like the bug was first introduced into 6.2 here.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs the changes from WordPress/gutenberg#58050 to core.
These changes fix the incorrect application of a custom root selector in theme.json.
To test:
npm run test:php -- --filter Tests_Theme_wpThemeJsonTrac ticket: https://core.trac.wordpress.org/ticket/60343
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.