Skip to content

Fix: Theme.json font settings in unit test#5942

Closed
aaronrobertshaw wants to merge 2 commits intoWordPress:trunkfrom
aaronrobertshaw:fix/theme-json-font-settings-in-unit-test
Closed

Fix: Theme.json font settings in unit test#5942
aaronrobertshaw wants to merge 2 commits intoWordPress:trunkfrom
aaronrobertshaw:fix/theme-json-font-settings-in-unit-test

Conversation

@aaronrobertshaw
Copy link
Copy Markdown

Syncs the changes from WordPress/gutenberg#56309 to core.

These changes fix incorrect font settings when testing the generation of a theme.json stylesheet.

To test:

npm run test:php -- --filter Tests_Theme_wpThemeJson

Trac ticket: https://core.trac.wordpress.org/ticket/60341


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@youknowriad
Copy link
Copy Markdown
Contributor

commit https://core.trac.wordpress.org/changeset/57497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants