Fix: Theme.json font settings in unit test

[aaronrobertshaw]

What?

Makes the font settings clearer in the main theme.json test (test_get_stylesheet).

Why?

I couldn't work out if the existing font settings were a mistake or if they were in fact trying to configure font families as if they were font sizes. It's probably best to define both font size and font family configurations for better coverage anyhow.

How?

• Updates the test's theme.json settings.typography.fontFamilies and introduces settings.typography.fontSizes
• Updates the expected styles to include matching CSS variable definitions and preset styles.

Testing Instructions

1. npm run test:unit:php:base -- --filter WP_Theme_JSON_Gutenberg_Test

Screenshots or screencast

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ phpunit/class-wp-theme-json-test.php

[glendaviesnz]

LGTM. Thanks for fixing this.

This change matches the test setup to how a real theme.json will be set up, and the tests still pass when run locally for me.

[glendaviesnz]

Nice tidy-up removing that nesting, I didn't notice that. Tests still passing for me if you want to merge.

[aaronrobertshaw]

Backport PR available in: WordPress/wordpress-develop#5942