Skip to content

Pattern Category: change show_tagcloud to false#5805

Closed
t-hamano wants to merge 1 commit intoWordPress:trunkfrom
t-hamano:60119/pattern-categori-show-tagcloud
Closed

Pattern Category: change show_tagcloud to false#5805
t-hamano wants to merge 1 commit intoWordPress:trunkfrom
t-hamano:60119/pattern-categori-show-tagcloud

Conversation

@t-hamano
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano commented Dec 20, 2023

Trac ticket: https://core.trac.wordpress.org/ticket/60119

Testing Instructions

Tag Cloud Block

  • Insert a Tag Cloud block.
  • Open the block sidebar.
  • "Pattern Categories" should not be displayed.

tag-cloud-block

Tag Cloud Widget

  • Activate Twenty Twenty-One theme.
  • Install the Classic Widgets plugin.
  • Access Appearance > Widgets and add a tag cloud widget.
  • "Pattern Categories" should not be displayed.

tag-cloud-widget


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@mukeshpanchal27
Copy link
Copy Markdown
Member

Thanks for the PR! LGTM and approved the PR.

Q: Do we needs to mention in docs that now Pattern Category did not show show_tagcloud?

@t-hamano
Copy link
Copy Markdown
Contributor Author

Thank you for your review! I think the Pattern categories are used to categorize patterns only on the dashboard or Site Editor, and are not intended to be displayed on the front end.

Therefore, I think that this change is a bug fix rather than a specification change, and no documentation is necessary.

@youknowriad
Copy link
Copy Markdown
Contributor

Thanks for the backport, this has been committed in https://core.trac.wordpress.org/changeset/57331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants