Navigation block: put navigation menu container in body#69665
Closed
Navigation block: put navigation menu container in body#69665
body#69665Conversation
stokesman
added
[Type] Bug
|
Size Change: +230 B (+0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
Member
I'd love to collaborate with you on using |
Contributor
Author
Thanks! I did open a draft to use Oh, I also just came across #68755 it would appear to be much like your branch but also aiming to make the submenus use the Popover API. I think moving forward with your PR seems best. It seems we could restore the focus trapping (for now) and still get the benefits of no JS required to open/close the dialog. It would fix #69363. I have it rebased locally and would be glad to take a look at getting the E2E tests passing. |
Member
|
Great! I was thinking actually of going to |
Contributor
Author
|
I don’t have too strong an opinion on the approach. At first I was fully aboard for the modal Ultimately, if the modal It’d be good to involve some more folks on which approach is most favorable. If we want to go with the modal |
Contributor
Author
|
This approach is feasible but I’m closing it in favor of #69720. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Drafted because:
<dialog>elementWhat?
Closes #69635
Ensures the Navigation block’s overlaid menu container is not confined by its parent/ancestor boxes.
Why?
The overlaid content is expected to behave as a root/top level element able to overlay the entire document.
How?
In the editor this uses
createPortalto make the container a child of thebodyelement. In the front end this usesappendChildto do the same.Testing Instructions
#69635 is an issue that is reproducible in Firefox or Safari so test with one of those browsers.
Here is markup for testing, though you’ll have to update the navigation for your site.
Screenshots or screencast
Editor
editor-nav-overlay-before.mp4
editor-nav-overlay-after.mp4
Front end
front-end-nav-overlay-before.mp4
front-end-nav-overlay-after.mp4