Try using Popover API to implement responsive navigation menu instead of using Interactivity API#63917
Closed
westonruter wants to merge 1 commit intotrunkfrom
Closed
Try using Popover API to implement responsive navigation menu instead of using Interactivity API#63917westonruter wants to merge 1 commit intotrunkfrom
westonruter wants to merge 1 commit intotrunkfrom
Conversation
westonruter
added
[Block] Navigation
|
Size Change: -261 B (-0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
This was referenced Mar 24, 2025
Contributor
More explanation about the |
Member
Author
|
Also, it would be trivial to implement a polyfill for Invoker Commands for browsers that don't support it yet. In this way, we could go ahead and ship the use of |
Member
Author
|
I'll likely be closing this PR in favor of @stokesman's PR #69720. |
Member
|
@westonruter There's also #68755, so we may want to compare the approaches and scope of the changes between that and #69720. In my PR (which admittedly is so far just experimental), I'm using popover for both the navigation overlay (by default only used on mobile) and for submenus (across all viewports). One thing to call out is that unfortunately the Interactivity API implementation for the overlay and submenus is very intertwined - maybe this was done to reduce some code to write, but to me that doesn't look like a good choice because there are so many subtle nuances in different behavior. And now it makes decoupling more painful than it should be. This is partly the reason why I think we need to consider changing both the overlay and the submenus implementation together. Because if you only change one of them to use popover or dialog, most of the Interactivity API code will still stick around for the other one. |
Member
Author
|
See #69720 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Core-50182, I commented:
This PR attempts to replace the use of the Interactivity API with the native Popover API instead. It was pretty easy to implement, however there is one key problem: there is no focus trap for popovers since they are non-modal. In contrast, the
dialogelement is a modal, but it currently requires opening with JavaScript. See comparison of dialog vs popover. In order to leverage this, I believe we have to wait for invoker commands to land in the web platform. See also An update on invokers: Invoker commands in HTML.Screenshots or screencast
Screen.recording.2024-07-24.17.56.31.webm