Layout block supports use str_contains#58251
Merged
Conversation
getdave
added
[Type] Code Quality
getdave
changed the title
Contributor
Author
|
@youknowriad Core supports We do not want to merge this change until after WordPress/wordpress-develop#5935 is committed to WP Core. |
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/block-supports/layout.php |
getdave
changed the title
str_contains
getdave
added
Needs PHP backport
dmsnell
approved these changes
Jan 26, 2024
Member
dmsnell
left a comment
dmsnell
left a comment
There was a problem hiding this comment.
This was already approved in the previous PR, and it looks solid.
getdave
added a commit
to getdave/wordpress-develop
that referenced
this pull request
Jan 30, 2024
youknowriad
added
Backported to WP Core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Makes changes suggested in per WordPress/wordpress-develop#5935 (comment).
Once merged I will update the Core PR to target this Gutenberg PR.
Why?
During the sync commit for #56171 changes were requested in order to merge to WP Core. This PR backports those changes to Gutenberg.As @dmsnell suggested it would be easier to commit the change to Gutenberg first and then proceed.
How?
Uses
str_contains.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast