Skip to content

Fix: PHP 8.1 deprecated warning strpos()#56171

Merged
Mamaduka merged 2 commits intoWordPress:trunkfrom
nk-o:patch-1
Dec 5, 2023
Merged

Fix: PHP 8.1 deprecated warning strpos()#56171
Mamaduka merged 2 commits intoWordPress:trunkfrom
nk-o:patch-1

Conversation

@nk-o
Copy link
Copy Markdown
Contributor

@nk-o nk-o commented Nov 15, 2023

What?

Fix for PHP warning

Why?

#56169

@nk-o nk-o requested a review from spacedmonkey as a code owner November 15, 2023 20:45
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 15, 2023
@github-actions
Copy link
Copy Markdown

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @nk-o! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@alexstine alexstine added the [Type] Bug An existing feature does not function as intended label Nov 16, 2023
Copy link
Copy Markdown
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@Mamaduka
Copy link
Copy Markdown
Member

Hi, @nk-o

Can you rebase this branch on top of the latest origin/trunk? It should resolve issues with CI checks.

@Mamaduka Mamaduka added the Needs PHP backport Needs PHP backport to Core label Nov 30, 2023
Copy link
Copy Markdown
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@getdave
Copy link
Copy Markdown
Contributor

getdave commented Jan 23, 2024

@youknowriad youknowriad added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Needs PHP backport Needs PHP backport to Core labels Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backported to WP Core Pull request that has been successfully merged into WP Core First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants