feat: raise if `remove_colums` is called with unknown column by default by TobiasPluecker · Pull Request #852 · Safe-DS/Library

TobiasPluecker · 2024-06-21T13:52:41Z

Closes #807

Summary of Changes

Added an optional, keyword-only parameter ignore_unknown_names: bool = False to the remove_columns method.
This parameter controls whether an error is raised when attempting to remove non-existent columns.
If ignore_unknown_names is set to False, the method checks for the existence of specified columns.
If ignore_unknown_names is set to True, non-existent columns are ignored, and no error is raised.

github-actions · 2024-06-21T13:54:09Z

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ PYTHON	black	7	0	0	1.31s
✅ PYTHON	mypy	7		0	3.25s
✅ PYTHON	ruff	7	0	0	0.4s
✅ REPOSITORY	git_diff	yes		no	0.68s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

src/safeds/data/tabular/containers/_table.py

lars-reimann · 2024-06-24T07:57:51Z

Since remove_columns is also used internally, you need to adjust some additional code and set ignore_unknown_names to True.

Update remove_columns function and related usage - Added documentation for the "ignore_unknown_names" parameter in the remove_columns function. - Updated the replace_column function to call remove_columns with "ignore_unknown_names=True" to maintain existing behavior. - Updated the examples in the documentation to include "ignore_unknown_names=True".

…th-unknown-column-by-default

codecov · 2024-06-28T09:37:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.63%. Comparing base (9880fe0) to head (f69393f).
Report is 49 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #852   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files         117      117           
  Lines        6057     6059    +2     
=======================================
+ Hits         5914     5916    +2     
  Misses        143      143

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…s-called-with-unknown-column-by-default

lars-reimann

👍

## [0.27.0](v0.26.0...v0.27.0) (2024-07-19) ### Features * join ([#870](#870)) ([5764441](5764441)), closes [#745](#745) * activation function for forward layer ([#891](#891)) ([5b5bb3f](5b5bb3f)), closes [#889](#889) * add `ImageDataset.split` ([#846](#846)) ([3878751](3878751)), closes [#831](#831) * add FunctionalTableTransformer ([#901](#901)) ([37905be](37905be)), closes [#858](#858) * add InvalidFitDataError ([#824](#824)) ([487854c](487854c)), closes [#655](#655) * add KNearestNeighborsImputer ([#864](#864)) ([fcdfecf](fcdfecf)), closes [#743](#743) * add moving average plot ([#836](#836)) ([abcf68a](abcf68a)) * add RobustScaler ([#874](#874)) ([62320a3](62320a3)), closes [#650](#650) [#873](#873) * add SequentialTableTransformer ([#893](#893)) ([e93299f](e93299f)), closes [#802](#802) * add temporal operations ([#832](#832)) ([06eab77](06eab77)) * added 'histogram_2d' in TablePlotter ([#903](#903)) ([4e65ba9](4e65ba9)), closes [#869](#869) [#798](#798) * added from_str_to_temporal and continues prediction ([#767](#767)) ([35f468a](35f468a)), closes [#806](#806) [#765](#765) [#740](#740) [#773](#773) * added GRU layer ([#845](#845)) ([d33cb5d](d33cb5d)) * Adds Dropout Layer ([#868](#868)) ([a76f0a1](a76f0a1)), closes [#848](#848) * dark mode for plots ([#911](#911)) ([5447551](5447551)), closes [#798](#798) * easily create a baseline model ([#811](#811)) ([8e1b995](8e1b995)), closes [#710](#710) * get first cell with value other than `None` ([#904](#904)) ([5a0cdb3](5a0cdb3)), closes [#799](#799) * hyperparameter optimization for fnn models ([#897](#897)) ([c1f66e5](c1f66e5)), closes [#861](#861) * implement violin plots ([#900](#900)) ([9f5992a](9f5992a)), closes [#867](#867) * plot decision tree ([#876](#876)) ([d3f81dc](d3f81dc)), closes [#856](#856) * prediction no longer takes a time series dataset only table ([#838](#838)) ([762e5c2](762e5c2)), closes [#837](#837) * raise if `remove_colums` is called with unknown column by default ([#852](#852)) ([8f78163](8f78163)), closes [#807](#807) * regularization strength for logistic classifier ([#866](#866)) ([9f74e92](9f74e92)), closes [#750](#750) * reorders parameters of RangeScaler and makes them keyword-only ([#847](#847)) ([2b82db7](2b82db7)), closes [#809](#809) * replace seaborn with matplotlib for box_plot ([#863](#863)) ([4ef078e](4ef078e)), closes [#805](#805) [#849](#849) * replaced seaborn with matplotlib for correlation_heatmap ([#850](#850)) ([d4680d4](d4680d4)), closes [#800](#800) [#849](#849) ### Bug Fixes * **deps:** bump urllib3 from 2.2.1 to 2.2.2 ([#842](#842)) ([b81bcd6](b81bcd6)), closes [#3122](https://github.com/Safe-DS/Library/issues/3122) [#3363](https://github.com/Safe-DS/Library/issues/3363) [#3122](https://github.com/Safe-DS/Library/issues/3122) [#3363](https://github.com/Safe-DS/Library/issues/3363) [#3406](https://github.com/Safe-DS/Library/issues/3406) [#3398](https://github.com/Safe-DS/Library/issues/3398) [#3399](https://github.com/Safe-DS/Library/issues/3399) [#3396](https://github.com/Safe-DS/Library/issues/3396) [#3394](https://github.com/Safe-DS/Library/issues/3394) [#3391](https://github.com/Safe-DS/Library/issues/3391) [#3316](https://github.com/Safe-DS/Library/issues/3316) [#3387](https://github.com/Safe-DS/Library/issues/3387) [#3386](https://github.com/Safe-DS/Library/issues/3386) * labels of correlation heatmap ([#894](#894)) ([a88a609](a88a609)), closes [#871](#871) * make multi-processing in baseline models more consistent ([#909](#909)) ([fa24560](fa24560)), closes [#907](#907) ### Performance Improvements * improved performance in various methods in `Image` and `ImageList` ([#879](#879)) ([134e7d8](134e7d8))

lars-reimann · 2024-07-19T13:02:14Z

🎉 This PR is included in version 0.27.0 🎉

The release is available on:

v0.27.0
GitHub release

Your semantic-release bot 📦🚀

saius02 added 2 commits June 21, 2024 14:48

zwischenstand

8b3d676

fertig

f2c0c7f

TobiasPluecker requested review from Gerhardsa0, Marsmaennchen221, lars-reimann and sibre28 as code owners June 21, 2024 13:52

lars-reimann changed the title ~~807 feat raise if remove colums is called with unknown column by default~~ feat: raise if remove colums is called with unknown column by default Jun 21, 2024

saius02 and others added 5 commits June 21, 2024 16:04

Ruff Error fixed completely

0c471f3

style: apply automated linter fixes

33b7d1e

style: apply automated linter fixes

8ebf36a

some refactoring

cd3b50a

style: apply automated linter fixes

7f1bfba

lars-reimann requested changes Jun 24, 2024

View reviewed changes

src/safeds/data/tabular/containers/_table.py Show resolved Hide resolved

TobiasPluecker and others added 5 commits June 24, 2024 16:40

removes empty line

d6c7fdb

style: apply automated linter fixes

c262362

Merge branch 'main' into 807-feat-raise-if-remove_colums-is-called-wi…

200b237

…th-unknown-column-by-default

update classification.ipynb

ef6414c

saius02 requested a review from a team as a code owner June 28, 2024 09:05

saius02 and others added 2 commits June 28, 2024 11:31

remove_columns updated in other functions

771dccc

style: apply automated linter fixes

b0da239

lars-reimann added 3 commits June 28, 2024 13:08

Merge branch 'refs/heads/main' into 807-feat-raise-if-remove_colums-i…

4038c19

…s-called-with-unknown-column-by-default

docs: undo changes to classification tutorial

f36fe41

docs: example with default behavior

f69393f

lars-reimann force-pushed the 807-feat-raise-if-remove_colums-is-called-with-unknown-column-by-default branch from 825843d to f69393f Compare June 28, 2024 11:14

lars-reimann approved these changes Jun 28, 2024

View reviewed changes

lars-reimann changed the title ~~feat: raise if remove colums is called with unknown column by default~~ feat: raise if remove_colums is called with unknown column by default Jun 28, 2024

lars-reimann merged commit 8f78163 into main Jun 28, 2024

lars-reimann deleted the 807-feat-raise-if-remove_colums-is-called-with-unknown-column-by-default branch June 28, 2024 11:31

lars-reimann added the released Included in a release label Jul 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: raise if `remove_colums` is called with unknown column by default#852

feat: raise if `remove_colums` is called with unknown column by default#852
lars-reimann merged 17 commits intomainfrom
807-feat-raise-if-remove_colums-is-called-with-unknown-column-by-default

TobiasPluecker commented Jun 21, 2024 •

edited by lars-reimann

Loading

Uh oh!

github-actions bot commented Jun 21, 2024 •

edited

Loading

Uh oh!

Uh oh!

lars-reimann commented Jun 24, 2024

Uh oh!

codecov bot commented Jun 28, 2024 •

edited

Loading

Uh oh!

lars-reimann left a comment

Uh oh!

lars-reimann commented Jul 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

TobiasPluecker commented Jun 21, 2024 • edited by lars-reimann Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Uh oh!

github-actions bot commented Jun 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦙 MegaLinter status: ✅ SUCCESS

Uh oh!

Uh oh!

lars-reimann commented Jun 24, 2024

Uh oh!

codecov bot commented Jun 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lars-reimann left a comment

Choose a reason for hiding this comment

Uh oh!

lars-reimann commented Jul 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TobiasPluecker commented Jun 21, 2024 •

edited by lars-reimann

Loading

github-actions bot commented Jun 21, 2024 •

edited

Loading

codecov bot commented Jun 28, 2024 •

edited

Loading