Skip to content

feat: infer input size of forward and LSTM layers#808

Merged
lars-reimann merged 9 commits intomainfrom
nn-fix
May 29, 2024
Merged

feat: infer input size of forward and LSTM layers#808
lars-reimann merged 9 commits intomainfrom
nn-fix

Conversation

@lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented May 29, 2024

Summary of Changes

  • Users no longer need to specify input sizes of forward and LSTM layers.
  • The constructor parameter output_size of these two layers has been renamed to neuron_count.

@github-actions
Copy link
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 23 0 0 1.53s
✅ PYTHON mypy 23 0 2.68s
✅ PYTHON ruff 23 0 0 0.33s
✅ REPOSITORY git_diff yes no 0.54s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 97.44%. Comparing base (69a780c) to head (4cca28c).
Report is 66 commits behind head on main.

Files Patch % Lines
src/safeds/ml/nn/_internal_model.py 94.44% 2 Missing ⚠️
src/safeds/ml/nn/layers/_forward_layer.py 80.00% 2 Missing ⚠️
src/safeds/ml/nn/layers/_lstm_layer.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
- Coverage   97.57%   97.44%   -0.13%     
==========================================
  Files         110      112       +2     
  Lines        5688     5684       -4     
==========================================
- Hits         5550     5539      -11     
- Misses        138      145       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann marked this pull request as ready for review May 29, 2024 12:06
@lars-reimann lars-reimann merged commit 098a07f into main May 29, 2024
@lars-reimann lars-reimann deleted the nn-fix branch May 29, 2024 12:07
lars-reimann pushed a commit that referenced this pull request May 29, 2024
## [0.26.0](v0.25.0...v0.26.0) (2024-05-29)

### Features

* `Table.count_row_if` ([#788](#788)) ([4137131](4137131)), closes [#786](#786)
* added method to load pretrained models from huggingface ([#790](#790)) ([dd8394b](dd8394b))
* infer input size of forward and LSTM layers ([#808](#808)) ([098a07f](098a07f))
* outline around dots of scatterplot ([#785](#785)) ([ee8acf7](ee8acf7))
* remove output conversions ([#792](#792)) ([46f2f5d](46f2f5d)), closes [#732](#732)
* shorten some excessively long names ([#787](#787)) ([1c3ea59](1c3ea59)), closes [#772](#772)
* specify column names in constructor of table transformers ([#795](#795)) ([69a780c](69a780c))
* store window size and forecast horizon in dataset ([#794](#794)) ([f07bc5a](f07bc5a))
* string operations on cells ([#791](#791)) ([4a17f76](4a17f76))

### Bug Fixes

* handling of boolean columns in column statistics ([#778](#778)) ([f61cceb](f61cceb))
* sort x values of line plot ([#782](#782)) ([74d8649](74d8649))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant