Skip to content

feat: remove output conversions#792

Merged
lars-reimann merged 5 commits intomainfrom
perf-build-internal-model-in-fit
May 20, 2024
Merged

feat: remove output conversions#792
lars-reimann merged 5 commits intomainfrom
perf-build-internal-model-in-fit

Conversation

@lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented May 20, 2024

Closes partially #732

Summary of Changes

Output conversions are the exact inversion of the input conversion, so there is no need to specify them again. Now, a neural network only takes an input conversion and a list of layers. This also gets rid of several errors that could occur if input and output conversions did not fit together.

In a later PR, the input conversion will also be removed, since they mirror datasets.

@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 20 0 0 1.41s
✅ PYTHON mypy 20 0 2.8s
✅ PYTHON ruff 20 0 0 0.32s
✅ REPOSITORY git_diff yes no 0.37s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (dd8394b) to head (cd24f78).
Report is 71 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #792      +/-   ##
==========================================
- Coverage   97.76%   97.73%   -0.04%     
==========================================
  Files         111      110       -1     
  Lines        5691     5659      -32     
==========================================
- Hits         5564     5531      -33     
- Misses        127      128       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann marked this pull request as ready for review May 20, 2024 12:45
@lars-reimann lars-reimann merged commit 46f2f5d into main May 20, 2024
@lars-reimann lars-reimann deleted the perf-build-internal-model-in-fit branch May 20, 2024 12:45
lars-reimann pushed a commit that referenced this pull request May 29, 2024
## [0.26.0](v0.25.0...v0.26.0) (2024-05-29)

### Features

* `Table.count_row_if` ([#788](#788)) ([4137131](4137131)), closes [#786](#786)
* added method to load pretrained models from huggingface ([#790](#790)) ([dd8394b](dd8394b))
* infer input size of forward and LSTM layers ([#808](#808)) ([098a07f](098a07f))
* outline around dots of scatterplot ([#785](#785)) ([ee8acf7](ee8acf7))
* remove output conversions ([#792](#792)) ([46f2f5d](46f2f5d)), closes [#732](#732)
* shorten some excessively long names ([#787](#787)) ([1c3ea59](1c3ea59)), closes [#772](#772)
* specify column names in constructor of table transformers ([#795](#795)) ([69a780c](69a780c))
* store window size and forecast horizon in dataset ([#794](#794)) ([f07bc5a](f07bc5a))
* string operations on cells ([#791](#791)) ([4a17f76](4a17f76))

### Bug Fixes

* handling of boolean columns in column statistics ([#778](#778)) ([f61cceb](f61cceb))
* sort x values of line plot ([#782](#782)) ([74d8649](74d8649))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants