Skip to content

Conversation

@lucas-a-pelegrino
Copy link
Contributor

@lucas-a-pelegrino lucas-a-pelegrino commented Dec 10, 2025

Proposed changes (including videos or screenshots)

Issue(s)

CORE-1404

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Removals

    • Removed the deprecated livechat:saveBusinessHour method. Users should migrate to the REST API endpoint /v1/livechat/business-hours.save for managing Livechat business hours configuration.
  • Chores

    • Added a changeset documenting this patch release.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2025

🦋 Changeset detected

Latest commit: e8a5708

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/license Patch
@rocket.chat/media-calls Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Dec 10, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2025

Walkthrough

Removes the deprecated Meteor server method livechat:saveBusinessHour, deletes its implementation file, removes its import from the livechat server index, and adds a changeset documenting a patch release for @rocket.chat/meteor. (49 words)

Changes

Cohort / File(s) Summary
Changeset documentation
\.changeset/twelve-years-act.md
Add patch changeset documenting removal of deprecated livechat:saveBusinessHour.
Server index cleanup
apps/meteor/app/livechat/server/index.ts
Remove import of ./methods/saveBusinessHour.
Deprecated method removal
apps/meteor/app/livechat/server/methods/saveBusinessHour.ts
Delete file containing livechat:saveBusinessHour Meteor method registration, module augmentation, deprecation logging, and related imports.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify there are no remaining references to livechat:saveBusinessHour across the codebase (clients, docs, tests).
  • Confirm the replacement REST endpoint (/v1/livechat/business-hours.save) or migration guidance is present where expected.

Possibly related PRs

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

  • dougfabris
  • pierre-lehnen-rc
  • KevLehman

Poem

🐰 I hopped through code with careful cheer,
A deprecated path I left right here.
One method gone, a changeset signed,
New routes await for those aligned.
🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The PR removes the deprecated livechat:saveBusinessHour method as indicated, but the linked issue CORE-1404 provides no specific requirements to validate compliance against. Review the linked issue CORE-1404 to confirm all specified requirements are met by this removal.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore!: removes deprecated method livechat:saveBusinessHour' accurately describes the main change—removal of a deprecated Livechat method.
Out of Scope Changes check ✅ Passed All changes are directly related to removing the deprecated livechat:saveBusinessHour method and its related imports, with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/CORE-1404

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a9702b4 and e8a5708.

📒 Files selected for processing (3)
  • .changeset/twelve-years-act.md (1 hunks)
  • apps/meteor/app/livechat/server/index.ts (0 hunks)
  • apps/meteor/app/livechat/server/methods/saveBusinessHour.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • apps/meteor/app/livechat/server/methods/saveBusinessHour.ts
  • apps/meteor/app/livechat/server/index.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • .changeset/twelve-years-act.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: CodeQL-Build
  • GitHub Check: CodeQL-Build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lucas-a-pelegrino lucas-a-pelegrino added this to the 8.0.0 milestone Dec 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.1GiB 1.1GiB +8.2MiB
rocketchat 355MiB 347MiB +8.5MiB
omnichannel-transcript-service 132MiB 132MiB -89KiB
queue-worker-service 132MiB 132MiB -95KiB
ddp-streamer-service 126MiB 126MiB -40KiB
account-service 113MiB 113MiB -41KiB
presence-service 110MiB 110MiB -35KiB
authorization-service 110MiB 110MiB -35KiB

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 19:52", "12/15 20:11 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
Loading

Statistics (last 21 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.2GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.1GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-37772
  • Baseline: develop
  • Timestamp: 2025-12-15 20:11:42 UTC
  • Historical data points: 21

Updated: Mon, 15 Dec 2025 20:11:43 GMT

@lucas-a-pelegrino lucas-a-pelegrino marked this pull request as ready for review December 15, 2025 19:09
@lucas-a-pelegrino lucas-a-pelegrino requested a review from a team as a code owner December 15, 2025 19:09
@ggazzo ggazzo requested review from a team as code owners December 15, 2025 19:25
lucas-a-pelegrino and others added 2 commits December 15, 2025 16:41
# Conflicts:
#	apps/meteor/app/livechat/server/methods/saveBusinessHour.ts
@lucas-a-pelegrino lucas-a-pelegrino added the stat: QA assured Means it has been tested and approved by a company insider label Dec 15, 2025
@lucas-a-pelegrino lucas-a-pelegrino added the stat: ready to merge PR tested and approved waiting for merge label Dec 15, 2025
@kodiakhq kodiakhq bot merged commit bb8effb into release-8.0.0 Dec 15, 2025
43 of 45 checks passed
@kodiakhq kodiakhq bot deleted the chore/CORE-1404 branch December 15, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants