-
Notifications
You must be signed in to change notification settings - Fork 12.9k
chore!: removes livechat:getAnalyticsChartData deprecated method
#36925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 474f96c The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughRemoves the deprecated Meteor DDP method Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant C as Client
participant D as Meteor DDP
participant S as Livechat Server
participant A as OmnichannelAnalytics
rect rgba(200,230,255,0.25)
note right of C: Old flow (before this change)
C->>D: call livechat:getAnalyticsChartData(options)
D->>S: Invoke registered method
S->>A: getAnalyticsChartData(utcOffset, executedBy, options)
A-->>S: ChartDataResult
S-->>D: Result
D-->>C: ChartDataResult
end
rect rgba(255,230,200,0.25)
note right of C: New flow (after removal)
C->>D: call livechat:getAnalyticsChartData(options)
D-->>C: Method not found (no handler registered)
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2025-09-19T15:15:04.642ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.0.0 #36925 +/- ##
=================================================
+ Coverage 66.43% 70.92% +4.48%
=================================================
Files 3276 3031 -245
Lines 109596 104339 -5257
Branches 20860 18371 -2489
=================================================
+ Hits 72814 74003 +1189
+ Misses 34116 28401 -5715
+ Partials 2666 1935 -731
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.changeset/fifty-rice-smash.md (2)
2-3: Confirm all affected packages get a major bump (ddp-client types may also be breaking).If the ddp-client (or any public client typings) removed the
livechat:getAnalyticsChartDatasignature, that package should also receive a major bump in this same changeset to signal the breaking API removal to downstreams.Proposed update if applicable:
--- "@rocket.chat/meteor": major +\"@rocket.chat/ddp-client\": major ---
5-5: Strengthen the breaking note with impact and migration guidance.Call out that clients will now receive “Method not found” and provide a brief migration note or explicit “no replacement” statement plus references (issue/PR).
Proposed wording:
-Removes deprecated Realtime API method: `livechat:getAnalyticsChartData` +BREAKING: Removes deprecated Realtime API method `livechat:getAnalyticsChartData`. + +Impact: Servers no longer register this method; DDP callers will receive "Method not found". +Migration: Remove usages of this method in clients/integrations. If an alternative API exists, migrate accordingly and link it here. + +Refs: CTZ-53, PR #36925.I can draft the migration note once you confirm the intended replacement (if any).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.changeset/fifty-rice-smash.md(1 hunks)apps/meteor/app/livechat/server/index.ts(0 hunks)apps/meteor/app/livechat/server/methods/getAnalyticsChartData.ts(0 hunks)
💤 Files with no reviewable changes (2)
- apps/meteor/app/livechat/server/methods/getAnalyticsChartData.ts
- apps/meteor/app/livechat/server/index.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: 📦 Build Packages
- GitHub Check: CodeQL-Build
- GitHub Check: CodeQL-Build
f6eaabb to
70fdc50
Compare
e88d317 to
87470a4
Compare
87470a4 to
8416b1f
Compare
The merge-base changed after approval.
329ef07 to
8fa1cac
Compare
8416b1f to
e65354b
Compare
Proposed changes (including videos or screenshots)
This PR removes the
livechat:getAnalyticsChartDatadeprecated meteor method.Issue(s)
CTZ-53
Steps to test or reproduce
Further comments
Summary by CodeRabbit
Chores
Refactor