Conversation
soujay
changed the title
kentdr
approved these changes
Aug 25, 2024
bording
approved these changes
Aug 26, 2024
helenktsai
approved these changes
Aug 27, 2024
soujay
changed the title
kentdr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for
Symptoms
When attempting to connect to an instance of ServiceControl the following error is shown:
Who's affected
If you are receiving this error even though ServiceControl is confirmed to be running properly.
Root cause
ServiceInsights validations of proper HTTP headers being returned from ServiceControl are not case insensitive. If the casing of the HTTP headers being returned from ServiceControl are being changed in any way, the validations will fail. The HTTP specification indicates that headers are supposed to be case insensitive.
This PR ignores the case while performing string comparisons of the response header keys with the ServiceControlHeaders