Conversation
…aveMod=6 (Should Fix #118)
Fix library settings for OpenFAST C++ API libraries
* WaveMode was set to 0 instead of WaveDirMod (Fixes #246)
Closes issue #236
* Fix out-of-bounds memory access in C++ API This pull request attempts to address the heap-buffer-overflow error reported in Nalu-Wind nightly tests using LLVM address sanitizer. For details see: https://my.cdash.org/testDetails.php?test=45418647&build=1609666 * Fix out of bounds array access in the OpenFAST-CFD interface
This OOB error was reported in Nalu-Wind nightly testing by LLVM/Clang address sanitizer: https://my.cdash.org/testDetails.php?test=45554439&build=1613318 ==17307==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60300080c398 at pc 0x000000496f7f bp 0x7ffd323df520 sp 0x7ffd323decd0 READ of size 1025 at 0x60300080c398 thread T0 0x60300080c398 is located 0 bytes to the right of 24-byte region [0x60300080c380,0x60300080c398) This issue was reported by Jon Rood. The fix implemented is similar to the one discussed in #243.
Fix out-of-bounds array error in C++ API
…ocumentation with inclusion of an instruction to copy the r-test folder to build/reg_tests
…ression test' of the documentation
…g-test_Doc_update
Fixes #254 - Updates the testing documentation for Windows with instructions to copy r-test folder
Allowing number of Morison number to be 0 (see #79)
* Add a github actions workflow * Enable Actions on all branches
* Formatting and content updates * Improve the git workflow description * Restructure the developer docs sections * Consolidate and improve the installation docs * Cleanup acknowledgements * Improve the testing documentation * Update the README and add GA tracking * Add rtfd config file And bug fixes when warnings are treated as failures * Enable Doxygen for readthedocs * Update link to download the latest binaries * Minor bug fixes * Improve the regression testing docs * TravisCI: update macos image to 10.14 * Add CygWin installation instructions as appendix * Move bolded nonsections to subsections * Describe some CMake options * Remove redundancies and update the intro * Clean up and updates to the testing docs * Update CMake flags and minor formatting fixes Mostly converts lists to tables * Clean up in the developer docs * Change references to Mac to macOS
rafmudaf
added
Type: Enhancement
Module: BeamDyn
Module: AeroDyn
Module: HydroDyn
Module: ElastoDyn
Module: InflowWind
Module: SubDyn
Type: Build issue
System: Unix
System: Windows
System: CMake
System: Visual Studio
FAST Registry
Type: Testing
Type: Documentation
Module: TurbSim
System: MinGW/CygWin
Sytem: MATLAB/Simulink
labels
Collaborator
Author
|
@andrew-platt @ebranlard @ashesh2512 I've requested your review here mostly on the change log. Please let me know if I've missed anything. |
Collaborator
|
I added a note on the registry dependency. @rafmudaf, should more be said regarding this? |
Collaborator
Author
|
@andrew-platt I had a note on that in the general section: |
Collaborator
Author
|
I'll add the PR link to that comment so people can find further information |
andrew-platt
approved these changes
Nov 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete this sentence
THIS PULL REQUEST IS READY TO MERGE
Feature or improvement description
This pull request merges
devintomasterfor a tagged release,v2.2.0. See below for the proposed change log.Related issue, if one exists
None
Impacted areas of the software
See the change log.
Additional supporting information
Its been a long time! In an effort to improve internal processes, I suggest going forward with releasing OpenFAST v2.2.0 as there are major differences between the
masteranddevbranches, at the moment. As there is ongoing work in existing pull requests and upcoming pull requests, I anticipate another minor version release in the near future.Automated test results
The baseline results have changed since the last release and have been maintained up to date on
dev.Proposed change log
General
modules-extandmodules-localintomodulesand added module README'sC++ API
BeamDyn
--> NOTE: further improvements are in progress for this feature.
HydroDyn
VTK Visualization
Build system
Documentation
InflowWind
AeroDyn
SubDyn
ElastDyn
The following modules have minor bug fixes not listed above: