Fix out-of-bounds array error in C++ API#251
Merged
rafmudaf merged 1 commit intoOpenFAST:devfrom Feb 25, 2019
Merged
Conversation
This OOB error was reported in Nalu-Wind nightly testing by LLVM/Clang address sanitizer: https://my.cdash.org/testDetails.php?test=45554439&build=1613318 ==17307==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60300080c398 at pc 0x000000496f7f bp 0x7ffd323df520 sp 0x7ffd323decd0 READ of size 1025 at 0x60300080c398 thread T0 0x60300080c398 is located 0 bytes to the right of 24-byte region [0x60300080c380,0x60300080c398) This issue was reported by Jon Rood. The fix implemented is similar to the one discussed in OpenFAST#243.
Contributor
Author
|
This pull request is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This OOB error was reported in Nalu-Wind nightly testing by LLVM/Clang
address sanitizer:
https://my.cdash.org/testDetails.php?test=45554439&build=1613318
==17307==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60300080c398 at pc 0x000000496f7f bp 0x7ffd323df520 sp 0x7ffd323decd0 READ of size 1025 at 0x60300080c398 thread T0
0x60300080c398 is located 0 bytes to the right of 24-byte region [0x60300080c380,0x60300080c398)
This issue was reported by Jon Rood. The fix implemented is similar to
the one discussed in #243.